[dev] [commits] Horde branch master updated. e2e084a517dfe3c732b3147fddfb6d2cf481b65a

Chuck Hagenbuch chuck at horde.org
Sun May 30 01:52:07 UTC 2010


Quoting Michael M Slusarz <slusarz at horde.org>:

> The branch "master" has been updated.
> The following is a summary of the commits.
>
> from: ee79f8d86c51d357077099e6163014ad348107b2
>
> 2e856e3 Add ability to add auto-increment to columns
> 556ca7c Add executeWrite().
> e2e084a IMP tables now created via migration script
>
> -----------------------------------------------------------------------
>
> commit 2e856e3669ebc439d13bb8127b5ff29434525ad2
> Author: Michael M Slusarz <slusarz at curecanti.org>
> Date:   Mon May 24 17:50:50 2010 -0600
>
>     Add ability to add auto-increment to columns
>
>     Only tested on PostgreSQL
>
>  framework/Db/lib/Horde/Db/Adapter/Base/ColumnDefinition.php |   54  
> +++++++---
>  framework/Db/lib/Horde/Db/Adapter/Base/Schema.php           |    4 +
>  framework/Db/lib/Horde/Db/Adapter/Base/TableDefinition.php  |    9 ++
>  framework/Db/lib/Horde/Db/Adapter/Mssql/Schema.php          |   38 +++++++-
>  framework/Db/lib/Horde/Db/Adapter/Mysql/Schema.php          |    5 +-
>  framework/Db/lib/Horde/Db/Adapter/Oracle/Schema.php         |   53  
> ++++++++++
>  framework/Db/lib/Horde/Db/Adapter/Postgresql/Schema.php     |   58  
> +++++++++--
>  framework/Db/lib/Horde/Db/Adapter/Sqlite/Schema.php         |    2 +
>  framework/Db/package.xml                                    |    3 +-
>  9 files changed, 195 insertions(+), 31 deletions(-)

Horde_Db has an *extensive* unit test suite that I put a lot of effort  
into writing, porting, running, and fixing. Please don't add things  
like this without adding unit tests for the new feature.

-chuck


More information about the dev mailing list