[dev] [commits] Horde branch master updated. 2ebfadf463a0cb344470f58c307debdc53646cbf

Chuck Hagenbuch chuck at horde.org
Tue Jul 20 14:26:28 UTC 2010


Quoting Michael Rubinsky <mrubinsk at horde.org>:

> Quoting Chuck Hagenbuch <chuck at horde.org>:
>
>> Quoting Michael Rubinsky <mike at theupstairsroom.com>:
>>
>>> The branch "master" has been updated.
>>> The following is a summary of the commits.
>>>
>>> from: bd6d4a104b486bcff3b2091e4f07cdcec17ba7e6
>>>
>>> 2ebfadf no need for this to be a param, use a private member.
>>>
>>> -----------------------------------------------------------------------
>>>
>>> commit 2ebfadf463a0cb344470f58c307debdc53646cbf
>>> Author: Michael J. Rubinsky <mrubinsk at horde.org>
>>> Date:   Mon Jul 19 12:10:57 2010 -0400
>>>
>>>   no need for this to be a param, use a private member.
>>>
>>> mnemo/lib/Block/note.php |   19 ++++++++-----------
>>> 1 files changed, 8 insertions(+), 11 deletions(-)
>>>
>>> http://git.horde.org/diff.php/mnemo/lib/Block/note.php?rt=horde-git&r1=fabc7e43b5dc1d9e651f5a343eb49266e46a0b63&r2=2ebfadf463a0cb344470f58c307debdc53646cbf
>>
>> The idea was to cache the title, so that if there was an error we'd  
>> still have the actual note name. I know it probably wasn't working  
>> that way yet, but that was the idea behind making it a param.
>
> Ok. I did this because I didn't think hidden parameters were  
> supported...the name shows up in the UI and I'm seeing instances  
> when the values don't stick. I guess Horde_Block needs some tweaks  
> to support this.

Yeah, I think so.

-chuck


More information about the dev mailing list