[dev] [commits] Horde branch master updated. 8093932637eef9fdbb299b76c8d3057536eb8001

[Chuck Hagenbuch]

Quoting Ben Klang <ben at alkaloid.net>:

> commit 8093932637eef9fdbb299b76c8d3057536eb8001
> Author: Ben Klang <bklang at horde.org>
> Date:   Mon Oct 4 14:39:15 2010 -0400
>
>     Rebuild factory for Horde_Notification
>
>     Still need to so something different with the singleton method I  
> think.  Does it really belong in the class?
>
>  framework/Core/lib/Horde/Core/Binder/Notification.php  |   26  
> ----------------
>  framework/Core/lib/Horde/Core/Factory/Notification.php |   20 ++++++++++++
>  framework/Core/lib/Horde/Registry.php                  |    5 ++-
>  framework/Core/package.xml                             |   10 +++---
>  4 files changed, 29 insertions(+), 32 deletions(-)
>  delete mode 100644 framework/Core/lib/Horde/Core/Binder/Notification.php
>  create mode 100644 framework/Core/lib/Horde/Core/Factory/Notification.php

Imo no - the singleton() method should be removed entirely and the  
code in it inlined into the factory.

-chuck