[dev] [commits] Horde branch master updated. df3540692b01d54dcfb774fca84f8856df51d0ae

[Jan Schneider]

Zitat von "Michael J.Rubinsky" <mrubinsk at horde.org>:

>
> Quoting Jan Schneider <jan at horde.org>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: 3273163e42d26bf1afa916f8136aad9344671555
>>
>> bc5d7ce Use dialog view for events.
>
> Why? IMO, the event detail view really isn't a good fit for a modal  
> dialog - especially when we add event editing to the mix somewhere  
> down the line. I think the UI pattern where a "detail" page has a  
> differently themed header is more appropriate here, similar to how  
> JQM's nested lists are automatically styled differently to indicate  
> you are in a secondary level of navigation.

I don't have a strong opinion about that, but I think the event view  
is a perfect fit for a dialog, especially when we are going to use it  
for editing too. That's how we display events in the Ajax view too.
I see the flashing too now, though this might something about how we  
call that dialog. It works fine with the notice dialog.
Anyway, if you feel strong about that, I'm fine with a regular page.

>> kronolith/templates/mobile/event.html.php |    4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/bc5d7ce25d4d68c10007622dfd8bfb49e7dc9a37
>>
>> -----------------------------------------------------------------------
>>
>> commit df3540692b01d54dcfb774fca84f8856df51d0ae
>> Author: Jan Schneider <jan at horde.org>
>> Date:   Tue Nov 30 13:32:16 2010 +0100
>>
>>    Consistently use data theme A in all apps.
>
> Can we compromise on making this a preference then? I find the A  
> theme extremely bland and not as visually pleasing...

This is of course a matter of taste, I personally find it much nicer  
than the blueish B swatch. But that's not the point. Swatches in  
jQuery Mobile have a semantic meaning, at least you are suggested to  
use them that way. And I really enjoy not having to think about how to  
style certain elements and pages. If you don't like the swatches of  
the default theme, create a new one. *That* could be preference.  
Swatches rather should not.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/