[dev] [commits] Horde branch master updated. 02ac7465fee04eb6aa5be9dc772d93ce5519c0f2

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>
>>> The branch "master" has been updated.
>>> The following is a summary of the commits.
>>>
>>> from: 71d22179670254d38e4e59f7732b6e38ab04ae11
>>>
>>> 02ac746 Bug #9441: *Vastly* simplify dragdrop ghost positioning
>>>
>>> -----------------------------------------------------------------------
>>>
>>> commit 02ac7465fee04eb6aa5be9dc772d93ce5519c0f2
>>> Author: Michael M Slusarz <slusarz at curecanti.org>
>>> Date:   Fri Dec 10 10:07:24 2010 -0700
>>>
>>>   Bug #9441: *Vastly* simplify dragdrop ghost positioning
>>>
>>>   Not sure if I am missing something completely obvious, but there appears
>>>   to be no reason why we shouldn't be using clonePosition() to set the
>>>   initial position of the ghosted object.
>>
>> Because it breaks half of the use cases, please revert. Attached is  
>> my test suite.
>
> Nothing attached.
>
> And unfortunately, I can't directly revert as dragdrop2 is totally  
> broken if items are in scrollable containers.  This used to work fine.

Then try to find what broke it. It indeed used to work fine and it  
still is in Kronolith using draggables inside scrolled containers.  
With your changes, the event dragging blows up. So please don't  
rewrite the whole thing without testing all the other cases.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/