[dev] [commits] Horde branch master updated. a2e65967b70b0257d998ecab7cc3d4505fe78614

[Gunnar Wrobel]

Zitat von Chuck Hagenbuch <chuck at horde.org>:

> Quoting Gunnar Wrobel <p at rdus.de>:
>
>> commit a2e65967b70b0257d998ecab7cc3d4505fe78614
>> Author: Gunnar Wrobel <p at rdus.de>
>> Date:   Mon Jan 10 13:58:14 2011 +0100
>>
>>    Horde_Injector_DependencyFinder uses the concept of previous  
>> exceptions without extending from Horde_Exception (>=5.3 only).
>>
>> framework/Injector/lib/Horde/Injector/Exception.php |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/a2e65967b70b0257d998ecab7cc3d4505fe78614
>
> The injector is one of the most re-usable, general libraries we  
> have; I'd really rather not add more dependencies to it.

> At the least, doing this should add a dependency to the injector's  
> package.xml, no?

True, I overlooked that.

>
> But I'd much rather find another way to avoid this.

I committed an alternative that omits using the previous exception.  
This throws away some information (the previous stack trace) and only  
retains the error message. This may be helpful enough but given the  
complexity of the Injector dependencies this might also be information  
you consider crucial.

At the moment I don't see any alternatives besides avoiding the  
previous exception or adding the Horde_Exception dependency (given  
that we want to support PHP 5.2).

It is interesting though that you would like to avoid adding further  
dependencies to this base package. I totally agree and it matches my  
feelings concerning some other libraries we provide. But as already  
discussed on this list I think the tendency was to *always* have the  
package exceptions extend Horde_Exception. But I still wanted to  
continue that thread anyhow.

Cheers,

Gunnar

>
> -chuck
> -- 
> Horde developers mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org

-- 
Core Developer
The Horde Project

e: wrobel at horde.org
t: +49 700 6245 0000
w: http://www.horde.org

pgp: 9703 43BE
tweets: http://twitter.com/pardus_de
blog: http://log.pardus.de