[dev] Horde_Share_Base::listShares()

[Gunnar Wrobel]

Hi!

The function mentioned above does support several sorting/paging  
features ('from', 'count', 'sort_by', 'direction'). As far as I can  
tell none of these parameters are actively used within our code base  
(with the exception of 'sort_by' but 'name' seems to be the only  
setting used here). Currently only the Sql-Drivers supports these  
features and I wonder if we really need them.

Horde_Share_Base::listShares() is fully replaced within  
Horde_Share_Sql and Horde_Share_Sql_Hierarchical. For  
Horde_Share_Kolab and Horde_Share_Datatree  
Horde_Share_Base::listShares() is called which delegates to  
Horde_Share_{Datatree,Kolab}::_listShares(). The sorting/paging  
apparently should be handled within Horde_Share_Base::listShares() for  
these drivers. The current implementation is incomplete however.

I don't mind completing the implementation if necessary but there are  
some things that currently puzzle me. Assuming a user has a few  
thousand shares and we would use the paging feature for example:  
Wouldn't the current Horde_Share_Sql:listShares() quickly fill the  
Horde_Share_Base::_listcache with plenty of caching information that  
gets stored in the session? For every sort setting it would be the  
same thing. I also wonder a bit if that is actually information that  
should go into the session at all.

On the other hand there has been a lot of work put into the Share  
driver recently and as far as I understand it there is more to come. I  
just wanted to get some feedback to understand where this is heading  
and if I should ignore the topic for now.

Thanks!

Gunnar
-- 
Core Developer
The Horde Project

e: wrobel at horde.org
t: +49 700 6245 0000
w: http://www.horde.org

pgp: 9703 43BE
tweets: http://twitter.com/pardus_de
blog: http://log.pardus.de