[dev] Fwd: Text_diff changes for PHP5

Michael Rubinsky mrubinsk at horde.org
Sun Mar 6 16:46:04 UTC 2011



----- Forwarded message from Žilvinas Bartkus  
<zilvinas.bartkus at gmail.com> -----
    Date: Sun, 6 Mar 2011 18:00:57 +0200
    From: Žilvinas Bartkus <zilvinas.bartkus at gmail.com>
Subject: Text_diff changes for PHP5
      To: mrubinsk at horde.org

Dear Michael,

I saw you did last
commit<http://git.horde.org/co.php/framework/Text_Diff/Diff.php?rt=horde&ws=1&r=1.29>for
Text_Diff.

    - It still contained errors for assigning results of new as a reference,
    which was erroring on PHP5. Fix that.
    - Also there was as usage of *is_a* function on renderer which was
    deprecated. Upgraded so that it checks PHP version before using that
    function.


I attach fixed files. It would be great if you'd commit to CVS repository.

Thank you.

Žilvinas

----- End forwarded message -----

mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
An embedded message was scrubbed...
From: =?UTF-8?Q?=C5=BDilvinas_Bartkus?= <zilvinas.bartkus at gmail.com>
Subject: Text_diff changes for PHP5
Date: Sun, 6 Mar 2011 18:00:57 +0200
Size: 29461
URL: <http://lists.horde.org/archives/dev/attachments/20110306/0298a3c7/attachment-0001.mht>


More information about the dev mailing list