[dev] [commits] Horde branch master updated. e7a93ed9b2ec51950fdc74648b62915e0ca02018
Michael Rubinsky
mrubinsk at horde.org
Fri May 13 23:37:08 UTC 2011
Quoting Jan Schneider <jan at horde.org>:
>> Fix a number of issues with sqlng and sql driver
>>
>> - getShareCriteria() should be protected
>> - return value of Horde_Share_Sql::_getShareCriteria is not compatible
>> with Horde_Share_Sqlng::, and $perms need to be an array
>> instead of bitmask
>> so need to also override countOwners() and
>> listOwners() in the sqlng driver.
>
> Please add unit tests that show how the old revision was broken.
Yup, coming up - just ran out of time to finish implementing them :)
--
mike
The Horde Project (www.horde.org)
mrubinsk at horde.org
More information about the dev
mailing list