[dev] [commits] Horde branch master updated. 82e759e1813871b65962aa70a8900da5c96729c7

[Gunnar Wrobel]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Gunnar Wrobel <p at rdus.de>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: 387bf6f511b03d7c93a423156653a06cbf227bc1
>>
>> 82e759e Remove circular dependency between Horde_Exception and  
>> Horde_Translation.
>>
>> -----------------------------------------------------------------------
>>
>> commit 82e759e1813871b65962aa70a8900da5c96729c7
>> Author: Gunnar Wrobel <p at rdus.de>
>> Date:   Mon May 23 15:01:13 2011 +0200
>>
>>    Remove circular dependency between Horde_Exception and Horde_Translation.
>>
>>    As far as I can tell PEAR is unable to install packages with circular
>>    dependencies when using the --offline switch. As Horde_Translation
>
> This is a bug in the PEAR installer then.

Certainly.

But in this case I would consider having no circular dependency of the  
required deps to outweigh the benefit of deriving  
Horde_Translation_Exception from Horde_Exception in any case.

>
>>    uses Horde_Translation_Exception in just a single location - and there
>>    only for a coding error in the derived class - I feel the circular
>>    dependency should rather be removed.
>
> It should still be an exception though ;)

True, thanks for the catch.

Cheers,

Gunnar

>
> Jan.
>
> -- 
> Do you need professional PHP or Horde consulting?
> http://horde.org/consulting/
>
> -- 
> Horde developers mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org

-- 
Core Developer
The Horde Project

e: wrobel at horde.org
t: +49 700 6245 0000
w: http://www.horde.org

pgp: 9703 43BE
tweets: http://twitter.com/pardus_de
blog: http://log.pardus.de