[dev] [commits] Horde branch master updated. e64f4407ca0953fb66ff839d6fdca4b38f6c68f6

[Ralf Lang]

Am Donnerstag, 16. Juni 2011, 14:25:59 schrieb Jan Schneider:
> Zitat von Ralf Lang <lang at b1-systems.de>:
> > Am Mittwoch, 15. Juni 2011, 18:25:19 schrieb Jan Schneider:
> >> Zitat von Ralf Lang <lang at b1-systems.de>:
> >> > The branch "master" has been updated.
> >> > The following is a summary of the commits.
> >> > 
> >> > from: 37df1c58900d008df4daa0577aa551d07364e5ed
> >> > 
> >> > e64f440 [#10205] Now sorts users in ajax perms view and reuses the
> >> > sort result
> >> > 
> >> > ----------------------------------------------------------------------
> >> > -
> >> > 
> >> > commit e64f4407ca0953fb66ff839d6fdca4b38f6c68f6
> >> > Author: Ralf Lang <lang at b1-systems.de>
> >> > Date:   Thu Jun 9 17:04:22 2011 +0000
> >> > 
> >> >     [#10205] Now sorts users in ajax perms view and reuses the sort
> >> >     result
> >> >  
> >> >  kronolith/templates/chunks/permissions.inc |    6 ++++--
> >> >  1 files changed, 4 insertions(+), 2 deletions(-)
> >> > 
> >> > http://git.horde.org/horde-git/-/commit/e64f4407ca0953fb66ff839d6fdca4
> >> > b38 f6c68f6
> >> 
> >> How about adding an (optional, to not break BC) parameter to
> >> listUsers() to enable sorting? This way sorting only has to be
> >> implemented in one place. And Horde_Auth drivers can use a sorting
> >> that might be provided by the backend.
> >> 
> >> Jan.
> > 
> > Yeah, I like this and would do so. This will touch all auth backends
> > which sport listUsers(), right?
> 
> Yes. A default sorting method should be implemented in Horde_Auth_Base
> though.
> 
> Jan.

3ca351188b86348bb37d7b844bd83fbe6f336c9c 

some drivers already did sorting in code or in backend
adds backend sorting to sql driver
adds simple sort() if option is given to most drivers

The fallback php solution is a one-liner.
Do you want the separate method for design reasons?

-- 
Ralf Lang
Linux Consultant / Developer

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537