[dev] [commits] Horde branch master updated. e64f4407ca0953fb66ff839d6fdca4b38f6c68f6

[Ralf Lang]

Am Donnerstag, 16. Juni 2011, 15:11:05 schrieb Jan Schneider:
> > some drivers already did sorting in code or in backend
> 
> Those should be changed then. Subclasses must not have a different
> default value for optional arguments either.

Yes.

> 
> > adds backend sorting to sql driver
> 
> Customsql should have that too.

Haven't found the way yet. 
Have to check: Is 
"ORDER BY 1 ASC"
portable?

> > adds simple sort() if option is given to most drivers
> > 
> > The fallback php solution is a one-liner.
> > Do you want the separate method for design reasons?
> 
> It might make sense if at some point we want to sort with a different
> method, so you only have to change a single place. And you could move
> the if-check there too.

Done for some, rest following this night.
 
> The Composite driver should simply pass the parameter to the sub-class.

Done

-- 
Ralf Lang
Linux Consultant / Developer

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537