[dev] [commits] Build failed in Jenkins: Token #44

[Jan Schneider]

Zitat von Jan Schneider <jan at horde.org>:

>>     [exec] PHPUnit 3.5.11 by Sebastian Bergmann.
>>     [exec]
>>     [exec] .................................E..
>>     [exec]
>>     [exec] Time: 6 seconds, Memory: 6.00Mb
>>     [exec]
>>     [exec] There was 1 error:
>>     [exec]
>>     [exec] 1) Horde_Token_Unit_SqlTest::testIsValidUnique
>>     [exec] Horde_Token_Exception_Used: This token has been used before!
>>     [exec]
>>     [exec] <http://ci.horde.org/job/Token/ws/lib/Horde/Token/Base.php>:187
>>     [exec]  
>> <http://ci.horde.org/job/Token/ws/test/Horde/Token/BackendTestCase.php>:139
>>     [exec]
>>     [exec] FAILURES!
>>     [exec] Tests: 36, Assertions: 37, Errors: 1.
>>     [exec]
>>     [exec] Writing code coverage data to XML file, this may take a moment.
>>     [exec]
>>     [exec] Generating code coverage report, this may take a moment.
>
> I tracked this down to the fact that nonces are stored in the  
> token_id varchar field, which is going to break under certain  
> circumstances, because the nonces are binary strings. The first  
> bytes of this string are the timestamp, that's why suddenly *all*  
> tests fail.
> I don't think we want to use BLOBs here, because we need to search  
> for the token_ids, so the question is, why are the nonces binary  
> strings, or why do we store them unencoded?

Nevermind, found the issue.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/