[dev] [commits] Horde branch master updated. e99ee0db6b1c1e95cc7e9e135c653e95411ad39a

[Michael M Slusarz]

Quoting Gunnar Wrobel <p at rdus.de>:

> commit e99ee0db6b1c1e95cc7e9e135c653e95411ad39a
> Author: Gunnar Wrobel <p at rdus.de>
> Date:   Mon Jun 27 07:19:17 2011 +0200
>
>     Ensure that the log level is indeed an integer.
>
>     We frequently use statements such as Horde::logMessage($e, 'INFO');
>     when an exception occurs. logMessage() directly uses
>     Horde_Log_Logger::log() which expects an integer level when logging
>     but logMessage() transmits the priority name as string. An alternative
>     to my fix might be to use
>
>     $GLOBALS['injector']->getInstance('Horde_Log_Logger')->$priority($event);
>
>     within Horde::logMessage(). There is also an $options parameter in
>     Horde::logMessage() which seems obsolete.

This is incorrect.  ALL logging done by Horde::logMessage() is first  
routed through Horde_Core_Log_Logger, which does necessary string ->  
integer log conversions.  So this commit is unneeded and should be  
reverted.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]