[dev] Horde_Core_Factory_Base and E_STRICT

[Chuck Hagenbuch]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Gunnar Wrobel <wrobel at horde.org>:
>
>> Hi!
>>
>> The class "Horde_Core_Factory_Base" implements the method  
>> "create()" but nearly all derived factories use a method with  
>> additional parameters ($driver, $params, etc) which is not  
>> E_STRICT. What is the idea of "Horde_Core_Factory_Base" and the  
>> base "create()" method? Can it simply be removed? Or is just a  
>> problem on my side?
>
> This is super-annoying on PHP's part.  By removing the create()  
> definition in Horde_Core_Factory_Base, there is now NO indication  
> that a subclass needs to implement a create() method by looking at  
> the generated documentation for HCF_Base.
>
> Not sure if there is a way to indicate this via phpdoc, but at a  
> minimum I think we need to at least implement the class in HCF_Base  
> and then comment it out.

What is the point of Horde_Core_Factory_Base? I'd be inclined to remove it.

-chuck