[dev] [commits] Horde branch master updated. 3a34c30bc7c1a02ddb0a2bdf9c87279e7c339758

[Michael M Slusarz]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>
>>> The branch "master" has been updated.
>>> The following is a summary of the commits.
>>>
>>> from: 91bcb66038fc24b0f3dd4b90c2d5b22d203790e5
>>>
>>> 3a34c30 Revert "MASK_BASE is not used."
>>>
>>> -----------------------------------------------------------------------
>>>
>>> commit 3a34c30bc7c1a02ddb0a2bdf9c87279e7c339758
>>> Author: Michael M Slusarz <slusarz at curecanti.org>
>>> Date:   Mon Jul 25 23:22:34 2011 -0600
>>>
>>>   Revert "MASK_BASE is not used."
>>>
>>>   This reverts commit 5131230215dde79fdb5de1c90339813fad78ae8b.
>>>
>>>   This *is* needed - it indicates that the base menu items (e.g. Logout,
>>>   preferences) should not be displayed, because they are handled
>>>   elsewhere outside of the menu code.
>>>
>>>   This commit breaks display of menu items in dynamic views.
>>>
>>> framework/Core/lib/Horde/Menu.php |    8 +-------
>>> imp/index-dimp.php                |    2 +-
>>> 2 files changed, 2 insertions(+), 8 deletions(-)
>>>
>>> http://git.horde.org/horde-git/-/commit/3a34c30bc7c1a02ddb0a2bdf9c87279e7c339758
>>>
>>>
>>> __
>>> commits mailing list
>>> Frequently Asked Questions: http://horde.org/faq/
>>> To unsubscribe, mail: commits-unsubscribe at lists.horde.org
>>
>> But where is it used? I grepped through the whole code and didn't  
>> find a single instance.
>
> I believe the intention was to choose a mask value that would NEVER  
> be used internally within Horde_Menu.  In other words: if you pass  
> in MASK_BASE, this means to use only the mask entries specifically  
> created by the user without internally adding/alterning menu items.

MASK_RAW may have been a better descriptive constant for this  
behavior, but the H4 ship has already sailed.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]