[dev] [commits] Horde branch master updated. d841e06d0845e82701fb11b2bedb815a38a4500b

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>
>>> The branch "master" has been updated.
>>> The following is a summary of the commits.
>>>
>>> from: c697fa16ac93fe2cbfff292347b18323528bbdcf
>>>
>>> e26df9d Fix version number
>>> 5016355 Released Horde_Imap_Client-1.0.11
>>> d841e06 Development mode for Horde_Imap_Client-1.0.13
>>>
>>> -----------------------------------------------------------------------
>>>
>>> commit e26df9dcd703b2dd801f20445d778e48db43ccc6
>>> Author: Michael M Slusarz <slusarz at curecanti.org>
>>> Date:   Tue Aug 9 11:00:12 2011 -0600
>>>
>>>   Fix version number
>>>
>>> components/lib/Components/Release/Task/CommitPostRelease.php |    2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> http://git.horde.org/horde-git/-/commit/e26df9dcd703b2dd801f20445d778e48db43ccc6
>>
>> I'm not sure why you keep commiting this "fix", I already reverted  
>> it once. :) As you can see from your next two commits, this  
>> *breaks* updating the version number.
>
> Because this happens:
>
> slusarz at bigworm % ../../components/bin/horde-components release --pretend
> [...]
> [  INFO  ] Would run "git commit -m "Released Horde_Imap_Client-1.0.11"" now.
> [  INFO  ] Would run "git tag -f -m "Released Horde_Imap_Client-1.0.11."
>            horde_imap_client-1.0.11" now.
> [  INFO  ] Would add next version "1.0.12" with the initial note "" to
>            /disk2/src/horde/framework/Imap_Client/package.xml now.
> [  INFO  ] Would run "git add
>            /disk2/src/horde/framework/Imap_Client/package.xml" now.
> [  INFO  ] Would run "git commit -m "Development mode for
>            Horde_Imap_Client-1.0.11"" now.
>
> That last entry is obviously wrong.  I committed so that the commit  
> messages would be correct, because this output indicates that it is  
> NOT correct.
>
> I don't really understand how components works (not a dig on Gunnar  
> - it's just that such a modular design can be very hard to follow)  
> so I'm not sure the best place to fix this.

Maybe it's a difference between --pretend and live action, but what  
you *did* commit was a bump to 1.0.13 with the message "Development  
mode for Horde_Imap_Client-1.0.13".

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/