[dev] [commits] Horde branch master updated. 0ab296d075f6256f22bc74b935559b2ed34ad04d

[Jan Schneider]

Zitat von Ralf Lang <lang at b1-systems.de>:

> Am Freitag, 12. August 2011, 11:23:25 schrieb Jan Schneider:
>> > -----------------------------------------------------------------------
>> >
>> > commit 9c5ef6d16b8dbd144c95c991632e06d4c4c2b9f7
>> > Author: Ralf Lang <lang at b1-systems.de>
>> > Date:   Thu Aug 11 14:35:20 2011 +0200
>> >
>> >     Horde_Auth_Sql: Dynamically add 'lock' and 'badlogincount'
>> >
>> > capabilities depending on configuration [#10387]
>> >
>> >     Do some basic sanity checking
>> >
>> >  framework/Auth/lib/Horde/Auth/Sql.php |   63
>> >
>> > +++++++++++++++++++++++++++++++--
>> >
>> >  1 files changed, 60 insertions(+), 3 deletions(-)
>> >
>> > http://git.horde.org/horde-git/-/commit/9c5ef6d16b8dbd144c95c991632e06d4c
>> > 4c2b9f7
>>
>> Why do you lowercase the field names? That doesn't make sense.
>
> Because it's been done for password_field and username_field before and I
> wanted to be consistent with existing code.
> If this is unneeded legacy, I will drop it.

Since the driver can work with any legacy tables, we shouldn't alter  
the configured column names. If we need to normalize the fields at one  
point, that's fine, but the query should use the configured names  
literally. If necessary this should be changed for existing code too.

>> Also, please don't do any work-in-progress in the master branch.
>> master is the stable branch where we build releases. If you add new
>> features, and don't commit them atomically, use a branch, either
>> "develop" or a topic branch.
>
> [x] Done so now. Didn't find any project docs on when/how to use branches in
> the horde git repo.

http://wiki.horde.org/Doc/Dev/Branches

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/