[dev] [commits] Horde branch master updated. f0651e19dbd0eccb67c9aefcf4cd3b3ef51c69df

[Ralf Lang]

Am Samstag, 10. September 2011, 00:20:08 schrieb Jan Schneider:
> Zitat von Ralf Lang <lang at b1-systems.de>:
> > f0651e1 Make Factory more test-friendly by removing static call to
> > Passwd::getBackends() Add getter/setter method for a factory's
> > backends
> > 
> > -----------------------------------------------------------------------
> > 
> > commit f0651e19dbd0eccb67c9aefcf4cd3b3ef51c69df
> > Author: Ralf Lang <lang at b1-systems.de>
> > Date:   Fri Sep 9 20:01:25 2011 +0000
> > 
> >     Make Factory more test-friendly by removing static call to
> > 
> > Passwd::getBackends()
> > 
> >     Add getter/setter method for a factory's backends
> >  
> >  passwd/index.php                               |    3 +-
> >  passwd/lib/Factory/Driver.php                  |   36 ++++++++++++++-
> >  passwd/test/Passwd/Unit/Factory/DriverTest.php |   57
> > 
> > +++++++++++++++++++----
> > 
> >  3 files changed, 82 insertions(+), 14 deletions(-)

> I didn't look at the code, but I cannot imagine the factory is used
> often. Why not passing the backend hash to the factory directly?
> 
> Jan.

Not in the constructor (signature inherited from base class, which could be 
dropped). 
It would probably work inside the create method, changing its interface.




-- 
Ralf Lang
Linux Consultant / Developer

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537