[dev] [commits] Horde branch master updated. b0373bc44c9e6ff2aa3e2cdda1a6286450031668

[Jan Schneider]

Zitat von Michael J Rubinsky <mrubinsk at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>>> commit 75ba025682ade08bce9acf8f73cac47e8d9e9278
>>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>>> Date:   Mon Oct 24 13:31:12 2011 -0400
>>>
>>>   Need to tweak $event->end if this is a single instance of a  
>>> recurring event.
>>>
>>>   Bug: 10678
>>>
>>> kronolith/lib/Kronolith.php |   52  
>>> ++++++++++++++++++++++++++++++++++++------
>>> 1 files changed, 44 insertions(+), 8 deletions(-)
>>>
>>> http://git.horde.org/horde-git/-/commit/75ba025682ade08bce9acf8f73cac47e8d9e9278
>>
>> Most of this magic shouldn't be necessary, because Horde_Date takes  
>> care of it.
>
> If this is true, I don't understand the code then; Even if an event  
> recurs, $event->start and $event->end will always show the  
> *original* start/end times of the event (which is why we go through  
> similar magic earlier in the method if $showRecurrence == true).
>
> Without this change, if $showRecurrence == false, and the original  
> event is in the past (i.e., it's not the first recurrence) the event  
> will *not* be added to the results. This is because $event->end will  
> be in the past - and therefore before any of the values of $loopDate  
> in the while loop further down.

With "most of the magic" I meant the correction of the date/time  
properties after subtracting.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/