[dev] [commits] Horde branch develop updated. 95c6678a3181196508a6b99469f5632d776e9916

Michael M Slusarz slusarz at horde.org
Thu Nov 17 07:59:46 UTC 2011


Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> Can we have this is in lib/ or is there some awkward  
>>> directory-to-class-name-lookup going on in PEAR?
>>>
>>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>>
>>>> commit 95c6678a3181196508a6b99469f5632d776e9916
>>>> Author: Michael M Slusarz <slusarz at horde.org>
>>>> Date:   Tue Nov 15 19:01:12 2011 -0700
>>>>
>>>>  Add Cache clearing code to Horde postinstall script
>>>>
>>>> horde/docs/CHANGES      |    1 +
>>>> horde/install/horde.php |   57  
>>>> +++++++++++++++++++++++++++++++++++++++++++++++
>>>> horde/package.xml       |   21 ++++++++++++++--
>>>> 3 files changed, 76 insertions(+), 3 deletions(-)
>>>> create mode 100644 horde/install/horde.php
>>>>
>>>> http://git.horde.org/horde-git/-/commit/95c6678a3181196508a6b99469f5632d776e9916
>>
>> In lib, the classname would need to be 'lib_horde_postinstall'.  Awkward.
>>
>> Plus, this is not an application accessible library.  It doesn't  
>> semantically belong in lib/.
>
> Understood, though I'd rather not have yet another top-level folder,  
> especially if it only contains one file.

It contains one file right now.  There is no guarantee that it may not  
contain more files in the future, if other install-related tasks are  
added.

I personally don't have an issue with it.  None of the other  
directories make any sense at all for the purpose of this file.   
Forcing a file into a directory it doesn't belong solely to prevent a  
one-file directory from existing does not seem like the proper  
solution to me.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list