[dev] [commits] Horde branch develop updated. 2d030bcdddaeca3f1fd96fe067a2f82ece919fdd

Michael M Slusarz slusarz at horde.org
Tue Feb 7 21:09:10 UTC 2012


Quoting :

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> Zitat von Jan Schneider <jan at horde.org>:
>>>
>>>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>>>
>>>>> Quoting Jan Schneider <jan at horde.org>:
>>>>>
>>>>>> commit 2d030bcdddaeca3f1fd96fe067a2f82ece919fdd
>>>>>> Author: Jan Schneider <jan at horde.org>
>>>>>> Date:   Tue Feb 7 13:25:45 2012 +0100
>>>>>>
>>>>>> Hot fix: $val is an array for me.
>>>>>>
>>>>>> framework/Imap_Client/lib/Horde/Imap/Client/Data/Envelope.php |  
>>>>>>    6 +++++-
>>>>>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>>>>>
>>>>>> http://git.horde.org/horde-git/-/commit/2d030bcdddaeca3f1fd96fe067a2f82ece919fdd
>>>>>
>>>>> I believe this is caused by switching internal data structure  
>>>>> but cached/serialized data is still being used.  See if my  
>>>>> latest commit (which reverts the above fix) works for you.
>>>>
>>>> Looks good.
>>>
>>> No quite. I get this when deleting messages:
>>
>> I can't reproduce this.  What is the value type that is trying to  
>> be cloned?  Looking over the code, there doesn't appear to be a way  
>> for anything other than an object to exist at that point, since to  
>> insert a 'to' value into the object necessarily hits this code:
>>
>>                    $val->personal =  
>> Horde_Mime_Headers::sanityCheck($name, $val->personal, array(
>>                        'encode' => true
>>                    ));
>>
>> which would through an array/object access error.  So the only  
>> thing that could be happen would be via cached unserialized data.   
>> But the unserialize code would have caught that.
>
> This only happened in INBOX. And I had to clear this mailbox' cache  
> to get access to mail at all. So I can't check anymore what this  
> value was.

My guess is that it was a transitory error caused by bad data created  
between two commits.  I'm not going to follow-up further unless/until  
I can reliably reproduce with the current code.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list