[dev] Recent notification system init changes break rpc access to at least kronolith.

Michael M Slusarz slusarz at horde.org
Mon Feb 13 03:21:17 UTC 2012


Quoting Michael M Slusarz <slusarz at horde.org>:

> This is NOT good in _init():
>
>     $GLOBALS['kronolith_shares'] =  
> $GLOBALS['injector']->getInstance('Horde_Core_Factory_Share')->create();
>
> _init() should not be setting up these kind of systems (since  
> _init() will often times be run when not authenticated).  It should  
> only be setting up the basic environment to use the application --  
> e.g. factory bindings; essential features that are fully  
> self-contained within the application.
>
> (The timezone call and the linkTags code should be moved out of init also.)

I'll go ahead and handle this.  It should just be a matter of  
converting usage of $kronolith_shares to a factory instead  
(Kronolith_Shares).

michael


___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list