[dev] Horde_Group_Contactlists
Michael J Rubinsky
mrubinsk at horde.org
Thu Feb 16 23:50:55 UTC 2012
Quoting Michael M Slusarz <slusarz at horde.org>:
> Why does this exist when you can't configure this in config? It was
> added here:
>
> commit 92619b968b1e47d3b0af5f8efb23775fc26f4519
> Author: Jan Schneider <jan at horde.org>
> Date: Sat Mar 5 18:06:17 2011 +0100
>
> Implement Contactlists driver.
>
> .../Group/lib/Horde/Group/ContactListObject.php | 109 ------
> framework/Group/lib/Horde/Group/Contactlists.php | 377
> ++++----------------
> .../Group/test/Horde/Group/ContactlistTest.php | 73 ++++
> framework/Group/test/Horde/Group/Stub/Api.php | 97 +++++
> 4 files changed, 238 insertions(+), 418 deletions(-)
>
>
> At a minimum, this should not be living in Horde_Group. It should
> be moved to Horde_Core_Group_Contactlists, since it can not be used
> outside of Horde.
I believe this is a refactoring of the contactlist driver I wrote for
SAPO. It was written before we really heavily refactored for Horde 4,
which is probably why it's not in Core.
I agree though, that going forward this should be moved to Core (if we
even need to keep it in our tree).
--
mike
The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2200 bytes
Desc: PGP Public Key
URL: <http://lists.horde.org/archives/dev/attachments/20120216/20ec9d99/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6096 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.horde.org/archives/dev/attachments/20120216/20ec9d99/attachment-0003.bin>
More information about the dev
mailing list