[dev] [commits] Horde branch develop updated. 27dd50fcf3fa13e6e15922ab768b2c82f9bada79

[Jan Schneider]

Zitat von Ralf Lang <lang at b1-systems.de>:

> commit 56a39fa9e85690d97eb449370b127fc39b3324f5
> Author: Ralf Lang <lang at b1-systems.de>
> Date:   Tue Apr 3 11:57:14 2012 +0200
>
>     phpdoc
>
>  framework/Rdo/lib/Horde/Rdo/Factory.php |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/56a39fa9e85690d97eb449370b127fc39b3324f5

This page doesn't exist either.

> commit 455e40da7e48a289febb479c44ed35a0f562d712
> Author: Ralf Lang <lang at b1-systems.de>
> Date:   Tue Apr 3 11:58:03 2012 +0200
>
>     Implement ArrayAccess interface.
>     Mock offsetSet and offsetUnset,
>     implement offsetExists and offsetGet
>
>  framework/Rdo/lib/Horde/Rdo/List.php |   61  
> +++++++++++++++++++++++++++++++++-
>  1 files changed, 60 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/455e40da7e48a289febb479c44ed35a0f562d712

You should add tests for those too.

> commit 27dd50fcf3fa13e6e15922ab768b2c82f9bada79
> Author: Ralf Lang <lang at b1-systems.de>
> Date:   Tue Apr 3 12:04:48 2012 +0200
>
>     The driver uses and returns (arrays of) Category objects instead  
> of property arrays
>
>  sesha/lib/Driver/Sql.php         |   51  
> +++++++++++++++++--------------------
>  sesha/lib/Forms/CategoryList.php |    2 +-
>  sesha/lib/Forms/Stock.php        |    2 +-
>  sesha/list.php                   |    2 +-
>  4 files changed, 26 insertions(+), 31 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/27dd50fcf3fa13e6e15922ab768b2c82f9bada79

No need for else-clauses if you return inside the if-clause.

And I'm wondering if we should rename the driver to Sesha_Driver_Rdo.  
We have no precedence for this, and it's actually still using SQL in  
the backend. Just pondering ideas.

-- 
Jan Schneider
The Horde Project
http://www.horde.org/