[dev] [commits] Horde branch develop updated. 8a640c7b8da1c7a3d87fcbd3efc3b086d17ce03e
Michael J Rubinsky
mrubinsk at horde.org
Thu May 3 23:13:27 UTC 2012
FYI for any folks using develop's ActiveSync support.
These commits add the basics for EAS 12.1 support. This is a fairly
large change, especially to the logic involved in handling SYNC
requests. Things are currently working well on the devices I have
available for testing. However, none of the devices I have available
use the new "hanging" sync that 12.1 makes available, so I am unable
to test this portion of the code. There are very likely some bugs
hanging around in there.
A new configuration option has also been added that specifies the
highest EAS version to support. If you have devices that are not
working properly you can try lowering the version to either 12.0 or
2.5. Of course, you should still report the issue here so I can look
into it.
In the meantime, I'm trying to source a Windows 6.5 device (which from
what I have read has the most complete implementation for 12.1). If
anyone has one available that they are willing to donate or even
temporarily load to a good cause... ;)
Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:
> The branch "develop" has been updated.
> The following is a summary of the commits.
>
> from: 6049cc481bd557b1f6628fbd1ed0b4f919b6aa13
>
> 8e2f08d Add some more 12.1 command constants
> 93679d3 Add stubs for a EAS 12.1 SyncCache factory
> 9e6fa84 Refactor SYNC request handling.
> 8620709 Break out sub sections of incoming requests into different methods.
> ad5f7a7 Add migration for sync cache table
> c27ae16 First ugly attempt at 12.1 hanging sync requests.
> 7c15585 Update package.xml filelist
> 2158f28 Make support official
> 1be16e8 fix migration and some function signatures
> e02497d Check the current version before attempting to use the sync_cache
> a7d0433 Remove unused code
> eebfac4 These errors require a different wbxml output.
> 70ac966 Log this after authenticated so we have the username
> edffcde phpdoc
> 26b9065 Fix reveresed logic, make code easier to follow.
> 2fe9a0d wrapping, logging
> a16c8f3 Break out into it's own method, try to keep _handle() as
> clean as possible.
> 937fefb Break out _validateCollectionsFromCache
> 616b17b Fail early
> 8e43f8b Simplify
> ca1e91a Better variable names
> fdcadef Fix index name
> 8f7c362 Only unset once
> fbec126 simplify
> 036feb6 Add method for loading the last known syncstate for a given folder.
> 882d3ff Set the name of the sync_cache table
> ca992f6 Add default hierarchy value in sync_cache
> 1a83dc2 Fix field name
> 5bf7633 Simplify log entry
> eb47464 Exchange does not seem to send these headers for 12.1
> 965c353 Ensure we have a cmd and devid from all EAS version requests.
> 2c8cd95 Ensure we parse, and remember, the EAS version from 12.1 requests
> 24de61c We need deviceid and user to get the sync_cache
> cfe6c93 comments/todos
> 1c83275 Fix error handler
> 3b077e0 Break out into helper method, reuse code.
> becfb86 We don't support larger than 12.1 - use ==
> a1eb62d Fix logic
> 9bd911a return status for proper error handling
> 763883e This only applies in 12.1
> ca66ee3 TODO
> 8e0b70b Add ability to select highest EAS version to support in Horde.
> 0d696b7 Fix WBXML mapping for 12.0/12.1 attendee fields
> 8d0ee8a Fix parameter mismatch
> 6893914 Correctly handle missing state/synckey errors in collecton sync
> 5d7d74f Fix constant
> 2b7fc21 Fix parameter passing to getMessage()
> 6ded408 RIGHTSMANAGEMENTSUPPORT is not supported in 12.1
> 57a47c2 Fix constant names
> bf9e64c One more place where rightsmanagement needs to be removed
> 2c43fcc Fix index name
> a22eadd This should be the class name
> 022045a Fix methodname and array index
> 2360715 No need to set the synckey to zero here, the status code
> should be sufficient
> 16d911b Need to pass the full $collection here, not just the
> mimesupport value.
> 684f465 Add missing endTag
> 30d8baa Truncation might not be defined
> 633cb83 Add constants for mime support values
> 78fee4b phpdoc
> c279ad5 Implement ActiveSync MIME support.
> 124f6d7 ws
> 1bcee40 Remove debug output, commented out code etc...
> 690f45e Must use Horde_ActiveSync::getGetVars() to deal with base64
> encoded binary query parameters.
> 8a640c7 Update package.xml
>
> -----------------------------------------------------------------------
>
> commit 8e2f08dcbf2343f948728dca904f9095f3d952dc
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Fri Apr 27 12:08:45 2012 -0400
>
> Add some more 12.1 command constants
>
> framework/ActiveSync/lib/Horde/ActiveSync.php | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/8e2f08dcbf2343f948728dca904f9095f3d952dc
>
> -----------------------------------------------------------------------
>
> commit 93679d3c59280208bc457de5ed7d2d1048ac0c6f
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Fri Apr 27 12:09:33 2012 -0400
>
> Add stubs for a EAS 12.1 SyncCache factory
>
> framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 7 +++++++
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 10 ++++++++++
> 2 files changed, 17 insertions(+), 0 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/93679d3c59280208bc457de5ed7d2d1048ac0c6f
>
> -----------------------------------------------------------------------
>
> commit 9e6fa84869ab7eb8c9d21c31c86c6534c6f45a19
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Fri Apr 27 12:10:02 2012 -0400
>
> Refactor SYNC request handling.
>
> Prepare for supporting 12.1 requests where we can't rely on the order of
> the incoming wbxml tags to parse them. Add some 12.1 property parsing
> along the way.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 833
> +++++++-----
> 1 files changed, 475 insertions(+), 358 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/9e6fa84869ab7eb8c9d21c31c86c6534c6f45a19
>
> -----------------------------------------------------------------------
>
> commit 8620709c447a8ae53db8f801e264bf05abde56a1
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Fri Apr 27 13:44:08 2012 -0400
>
> Break out sub sections of incoming requests into different methods.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 815
> ++++++------
> 1 files changed, 422 insertions(+), 393 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/8620709c447a8ae53db8f801e264bf05abde56a1
>
> -----------------------------------------------------------------------
>
> commit ad5f7a70e57ffa6f47a8516765f0edd8d8a3c40f
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 14:49:43 2012 -0400
>
> Add migration for sync cache table
>
> .../migration/Horde/ActiveSync/9_horde_activesync_add_cache.php |
> 21 +++++
> 1 files changed, 21 insertions(+), 0 deletions(-)
> create mode 100644
> framework/ActiveSync/migration/Horde/ActiveSync/9_horde_activesync_add_cache.php
>
> http://git.horde.org/horde-git/-/commit/ad5f7a70e57ffa6f47a8516765f0edd8d8a3c40f
>
> -----------------------------------------------------------------------
>
> commit c27ae16a87d7ae81d818b6de98c6436248e5b97e
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 14:50:43 2012 -0400
>
> First ugly attempt at 12.1 hanging sync requests.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php | 112 +-
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php |
> 735 +++++-
> framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 50 +-
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 157 ++-
> 4 files changed, 986 insertions(+), 68 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/c27ae16a87d7ae81d818b6de98c6436248e5b97e
>
> -----------------------------------------------------------------------
>
> commit 7c155858f8726e89fdf63bd9e4023fab5b0a958c
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 14:51:26 2012 -0400
>
> Update package.xml filelist
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 12
> ++++++------
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 8 ++++----
> framework/ActiveSync/package.xml | 8 +++++---
> 3 files changed, 15 insertions(+), 13 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/7c155858f8726e89fdf63bd9e4023fab5b0a958c
>
> -----------------------------------------------------------------------
>
> commit 2158f28fda198a4ceb217b53edbf10bba230ffa1
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 15:13:47 2012 -0400
>
> Make support official
>
> framework/ActiveSync/lib/Horde/ActiveSync.php | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/2158f28fda198a4ceb217b53edbf10bba230ffa1
>
> -----------------------------------------------------------------------
>
> commit 1be16e84d13b74df6c41fb8fbcfb4478d20eb316
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 15:18:55 2012 -0400
>
> fix migration and some function signatures
>
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php |
> 6 ++--
> .../migration/Horde/ActiveSync/9_horde_activesync_add_cache.php | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/1be16e84d13b74df6c41fb8fbcfb4478d20eb316
>
> -----------------------------------------------------------------------
>
> commit e02497d0b60f40b222ef2bb1ae19656fe8b67a0a
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 16:48:52 2012 -0400
>
> Check the current version before attempting to use the sync_cache
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php | 5 +-
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php |
> 349 +++---
> 2 files changed, 178 insertions(+), 176 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/e02497d0b60f40b222ef2bb1ae19656fe8b67a0a
>
> -----------------------------------------------------------------------
>
> commit a7d0433e664f774cd628edad76ebeb05b861804d
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 16:51:01 2012 -0400
>
> Remove unused code
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 14
> +-----------
> 1 files changed, 1 insertions(+), 13 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/a7d0433e664f774cd628edad76ebeb05b861804d
>
> -----------------------------------------------------------------------
>
> commit eebfac4b9ca3fb888a0077eb17f989e4ba486885
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 16:51:23 2012 -0400
>
> These errors require a different wbxml output.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 37
> ++++++++----
> 1 files changed, 26 insertions(+), 11 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/eebfac4b9ca3fb888a0077eb17f989e4ba486885
>
> -----------------------------------------------------------------------
>
> commit 70ac96633f575f370b03c79ae6bcb672ad309721
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 16:54:30 2012 -0400
>
> Log this after authenticated so we have the username
>
> framework/ActiveSync/lib/Horde/ActiveSync.php | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/70ac96633f575f370b03c79ae6bcb672ad309721
>
> -----------------------------------------------------------------------
>
> commit edffcde617b9f5ca55207e8858c13996ef580b76
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 16:55:00 2012 -0400
>
> phpdoc
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/edffcde617b9f5ca55207e8858c13996ef580b76
>
> -----------------------------------------------------------------------
>
> commit 26b906552e14618696e174152d32ea0dc544bab0
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:00:09 2012 -0400
>
> Fix reveresed logic, make code easier to follow.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 12
> +++++++++---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/26b906552e14618696e174152d32ea0dc544bab0
>
> -----------------------------------------------------------------------
>
> commit 2fe9a0d77b98f08177dc974595ad64465a4fdce0
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:10:55 2012 -0400
>
> wrapping, logging
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 35
> ++++++------
> 1 files changed, 18 insertions(+), 17 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/2fe9a0d77b98f08177dc974595ad64465a4fdce0
>
> -----------------------------------------------------------------------
>
> commit a16c8f3a5f42af421ccac545a020aca21f342e23
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:11:07 2012 -0400
>
> Break out into it's own method, try to keep _handle() as clean
> as possible.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 58
> +++++++-----
> 1 files changed, 36 insertions(+), 22 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/a16c8f3a5f42af421ccac545a020aca21f342e23
>
> -----------------------------------------------------------------------
>
> commit 937fefb7b75d42c6e28f38bc22ed6d2eed5c5a17
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:15:39 2012 -0400
>
> Break out _validateCollectionsFromCache
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 73
> ++++++-----
> 1 files changed, 40 insertions(+), 33 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/937fefb7b75d42c6e28f38bc22ed6d2eed5c5a17
>
> -----------------------------------------------------------------------
>
> commit 616b17b1df70311befa98e419b5de8510f245de0
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:17:20 2012 -0400
>
> Fail early
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/616b17b1df70311befa98e419b5de8510f245de0
>
> -----------------------------------------------------------------------
>
> commit 8e43f8bf7edf514bbb04c71dbb52a06985eebddc
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:26:14 2012 -0400
>
> Simplify
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/8e43f8bf7edf514bbb04c71dbb52a06985eebddc
>
> -----------------------------------------------------------------------
>
> commit ca1e91ae47dfd440771d40a2818bc9f07a47a02c
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:27:07 2012 -0400
>
> Better variable names
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 24
> ++++++------
> 1 files changed, 12 insertions(+), 12 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/ca1e91ae47dfd440771d40a2818bc9f07a47a02c
>
> -----------------------------------------------------------------------
>
> commit fdcadefff4edcf96ff597bff15dc355edf866e25
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:27:29 2012 -0400
>
> Fix index name
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/fdcadefff4edcf96ff597bff15dc355edf866e25
>
> -----------------------------------------------------------------------
>
> commit 8f7c3622bf6242038b74b881259922e23c11b48a
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:27:48 2012 -0400
>
> Only unset once
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/8f7c3622bf6242038b74b881259922e23c11b48a
>
> -----------------------------------------------------------------------
>
> commit fbec1266336fb6c336dff4a95881ce924253f51c
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Sun Apr 29 17:28:00 2012 -0400
>
> simplify
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 8 +-------
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/fbec1266336fb6c336dff4a95881ce924253f51c
>
> -----------------------------------------------------------------------
>
> commit 036feb64e8af2835e1a2e7d22f977c93191fb3fb
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:08:11 2012 -0400
>
> Add method for loading the last known syncstate for a given folder.
>
> Simplifies and combines 3 queries into a single query, and fixes issue
> where some clients do not issue a SYNC request in response to the first
> known sync_key. This allows the PING request to pick up on any pending
> changes and request that he SYNC be issued.
>
> framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php | 11 ++-
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 82
> +++++++++-----
> 2 files changed, 65 insertions(+), 28 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/036feb64e8af2835e1a2e7d22f977c93191fb3fb
>
> -----------------------------------------------------------------------
>
> commit 882d3ff153a0cccdf6ea50bc1f9a0317e4b749c9
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:11:18 2012 -0400
>
> Set the name of the sync_cache table
>
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/882d3ff153a0cccdf6ea50bc1f9a0317e4b749c9
>
> -----------------------------------------------------------------------
>
> commit ca992f65ed85a68d725e917a5ba5c31fb196ab15
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:11:44 2012 -0400
>
> Add default hierarchy value in sync_cache
>
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/ca992f65ed85a68d725e917a5ba5c31fb196ab15
>
> -----------------------------------------------------------------------
>
> commit 1a83dc242de8e81fec1c4007a49a5bc0ef5e8576
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:12:05 2012 -0400
>
> Fix field name
>
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/1a83dc242de8e81fec1c4007a49a5bc0ef5e8576
>
> -----------------------------------------------------------------------
>
> commit 5bf7633fed8c2bf23ee4adcb93fed4a9327a9969
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:12:17 2012 -0400
>
> Simplify log entry
>
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/5bf7633fed8c2bf23ee4adcb93fed4a9327a9969
>
> -----------------------------------------------------------------------
>
> commit eb474642351e63ca8e265a13b025d7f28edcd85b
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:13:51 2012 -0400
>
> Exchange does not seem to send these headers for 12.1
>
> framework/ActiveSync/lib/Horde/ActiveSync.php | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/eb474642351e63ca8e265a13b025d7f28edcd85b
>
> -----------------------------------------------------------------------
>
> commit 965c35302b527ef6b63480beabb39153f57f8400
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:17:57 2012 -0400
>
> Ensure we have a cmd and devid from all EAS version requests.
>
> framework/ActiveSync/lib/Horde/ActiveSync.php | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/965c35302b527ef6b63480beabb39153f57f8400
>
> -----------------------------------------------------------------------
>
> commit 2c8cd95b2c143ad1f518553b900b06e4ad8c0329
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:18:25 2012 -0400
>
> Ensure we parse, and remember, the EAS version from 12.1 requests
>
> framework/ActiveSync/lib/Horde/ActiveSync.php | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/2c8cd95b2c143ad1f518553b900b06e4ad8c0329
>
> -----------------------------------------------------------------------
>
> commit 24de61c4bc67f9431db2a96db09234f714c38ad7
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:21:48 2012 -0400
>
> We need deviceid and user to get the sync_cache
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 11
> +++++------
> 1 files changed, 5 insertions(+), 6 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/24de61c4bc67f9431db2a96db09234f714c38ad7
>
> -----------------------------------------------------------------------
>
> commit cfe6c93e9a108a3212b51e517cf936f0ec684473
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:27:18 2012 -0400
>
> comments/todos
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 22
> +++++++----
> 1 files changed, 14 insertions(+), 8 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/cfe6c93e9a108a3212b51e517cf936f0ec684473
>
> -----------------------------------------------------------------------
>
> commit 1c8327529e9f53e977db679475dbdcf88dad46b1
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:28:09 2012 -0400
>
> Fix error handler
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/1c8327529e9f53e977db679475dbdcf88dad46b1
>
> -----------------------------------------------------------------------
>
> commit 3b077e0b38738bb92e5e525e185e8f8e2b87e4db
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:29:13 2012 -0400
>
> Break out into helper method, reuse code.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 147
> +++++-------
> 1 files changed, 59 insertions(+), 88 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/3b077e0b38738bb92e5e525e185e8f8e2b87e4db
>
> -----------------------------------------------------------------------
>
> commit becfb861daecf56ab18204812d4c08bfa454fe63
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:30:08 2012 -0400
>
> We don't support larger than 12.1 - use ==
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/becfb861daecf56ab18204812d4c08bfa454fe63
>
> -----------------------------------------------------------------------
>
> commit a1eb62d1cec19966e3fc9056420c8b6a32ce94ea
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:30:52 2012 -0400
>
> Fix logic
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/a1eb62d1cec19966e3fc9056420c8b6a32ce94ea
>
> -----------------------------------------------------------------------
>
> commit 9bd911a9dfba01676feebfa1b5bb780d9d70cb9e
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:32:34 2012 -0400
>
> return status for proper error handling
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 32
> +++++++-----
> 1 files changed, 19 insertions(+), 13 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/9bd911a9dfba01676feebfa1b5bb780d9d70cb9e
>
> -----------------------------------------------------------------------
>
> commit 763883e746accc6d9567597120a61c57acb863b6
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:33:03 2012 -0400
>
> This only applies in 12.1
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 27
> ++++++-----
> 1 files changed, 15 insertions(+), 12 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/763883e746accc6d9567597120a61c57acb863b6
>
> -----------------------------------------------------------------------
>
> commit ca66ee3c28c4c6cbda5d1a441d846a772eea61d6
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:33:32 2012 -0400
>
> TODO
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/FolderSync.php | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/ca66ee3c28c4c6cbda5d1a441d846a772eea61d6
>
> -----------------------------------------------------------------------
>
> commit 8e0b70b65c18ab1e1fe329da67841ed61b7dce40
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 12:33:53 2012 -0400
>
> Add ability to select highest EAS version to support in Horde.
>
> horde/config/conf.xml | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/8e0b70b65c18ab1e1fe329da67841ed61b7dce40
>
> -----------------------------------------------------------------------
>
> commit 0d696b7c46b45b9e7565734632ce0628f4f4096b
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 16:10:56 2012 -0400
>
> Fix WBXML mapping for 12.0/12.1 attendee fields
>
> framework/ActiveSync/lib/Horde/ActiveSync/Wbxml.php | 4 ++--
> framework/Core/lib/Horde/Core/Factory/ActiveSyncServer.php | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/0d696b7c46b45b9e7565734632ce0628f4f4096b
>
> -----------------------------------------------------------------------
>
> commit 8d0ee8a233f54d2fa0881e306c96e45a8225d707
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 16:12:22 2012 -0400
>
> Fix parameter mismatch
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/8d0ee8a233f54d2fa0881e306c96e45a8225d707
>
> -----------------------------------------------------------------------
>
> commit 689391488739f7a79da8302ff7a6999932901fe9
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 16:14:50 2012 -0400
>
> Correctly handle missing state/synckey errors in collecton sync
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 209
> ++++++------
> 1 files changed, 106 insertions(+), 103 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/689391488739f7a79da8302ff7a6999932901fe9
>
> -----------------------------------------------------------------------
>
> commit 5d7d74fb4bf2bc2590c181f72f5b97c3c94f590a
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 16:16:05 2012 -0400
>
> Fix constant
>
> kronolith/lib/Event.php | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/5d7d74fb4bf2bc2590c181f72f5b97c3c94f590a
>
> -----------------------------------------------------------------------
>
> commit 2b7fc216d4480b81c1337f8930ccab1859a31236
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 17:08:22 2012 -0400
>
> Fix parameter passing to getMessage()
>
> framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/2b7fc216d4480b81c1337f8930ccab1859a31236
>
> -----------------------------------------------------------------------
>
> commit 6ded408eb44feccd6d22a5bd8e70fb75e93f7f17
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 17:09:05 2012 -0400
>
> RIGHTSMANAGEMENTSUPPORT is not supported in 12.1
>
> .../ActiveSync/lib/Horde/ActiveSync/Request/ItemOperations.php |
> 6 +---
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/6ded408eb44feccd6d22a5bd8e70fb75e93f7f17
>
> -----------------------------------------------------------------------
>
> commit 57a47c2971f93580530e3c2da18c82e1fbf1efa7
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 17:10:06 2012 -0400
>
> Fix constant names
>
> .../ActiveSync/lib/Horde/ActiveSync/Request/ItemOperations.php |
> 14 ++--
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/57a47c2971f93580530e3c2da18c82e1fbf1efa7
>
> -----------------------------------------------------------------------
>
> commit bf9e64c21f5a1dc191a498c947e9c3c28d74ce17
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 17:10:49 2012 -0400
>
> One more place where rightsmanagement needs to be removed
>
> .../ActiveSync/lib/Horde/ActiveSync/Request/ItemOperations.php |
> 6 -----
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/bf9e64c21f5a1dc191a498c947e9c3c28d74ce17
>
> -----------------------------------------------------------------------
>
> commit 2c43fcc8af7c49eb9f869fd1f2ff45bb8dde88b4
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Wed May 2 17:11:13 2012 -0400
>
> Fix index name
>
> .../ActiveSync/lib/Horde/ActiveSync/Request/ItemOperations.php |
> 8 ++--
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/2c43fcc8af7c49eb9f869fd1f2ff45bb8dde88b4
>
> -----------------------------------------------------------------------
>
> commit a22eadd0f88ce99993e66933721432741620e497
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 11:03:13 2012 -0400
>
> This should be the class name
>
> framework/ActiveSync/lib/Horde/ActiveSync/Message/Mail.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/a22eadd0f88ce99993e66933721432741620e497
>
> -----------------------------------------------------------------------
>
> commit 022045ac4ecd505f9c0a2128e9699037065fcbca
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 11:04:18 2012 -0400
>
> Fix methodname and array index
>
> .../ActiveSync/lib/Horde/ActiveSync/Request/ItemOperations.php |
> 6 +++-
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/022045ac4ecd505f9c0a2128e9699037065fcbca
>
> -----------------------------------------------------------------------
>
> commit 2360715c8baa3a56febac51d4a54336370985ae1
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 11:05:07 2012 -0400
>
> No need to set the synckey to zero here, the status code should
> be sufficient
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/2360715c8baa3a56febac51d4a54336370985ae1
>
> -----------------------------------------------------------------------
>
> commit 16d911b42ec13f2bd985736e1b7eba099a9fde72
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 11:05:32 2012 -0400
>
> Need to pass the full $collection here, not just the mimesupport value.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/16d911b42ec13f2bd985736e1b7eba099a9fde72
>
> -----------------------------------------------------------------------
>
> commit 684f465f74d98f2f7038a0c5b3d7baaa03e925f9
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 11:05:59 2012 -0400
>
> Add missing endTag
>
> framework/ActiveSync/lib/Horde/ActiveSync/Request/Sync.php | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/684f465f74d98f2f7038a0c5b3d7baaa03e925f9
>
> -----------------------------------------------------------------------
>
> commit 30d8baa34deeb49f25c97650f31503839c194ffe
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 11:06:40 2012 -0400
>
> Truncation might not be defined
>
> framework/Core/lib/Horde/Core/ActiveSync/Driver.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/30d8baa34deeb49f25c97650f31503839c194ffe
>
> -----------------------------------------------------------------------
>
> commit 633cb83831f1c63229b9b33b4c858dc5101bbb93
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 11:07:08 2012 -0400
>
> Add constants for mime support values
>
> framework/ActiveSync/lib/Horde/ActiveSync.php | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/633cb83831f1c63229b9b33b4c858dc5101bbb93
>
> -----------------------------------------------------------------------
>
> commit 78fee4b26206a329abfeb26c12e4254b280241a4
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 14:54:07 2012 -0400
>
> phpdoc
>
> framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/78fee4b26206a329abfeb26c12e4254b280241a4
>
> -----------------------------------------------------------------------
>
> commit c279ad54502758d7be1d47326a05dc62ba4a2480
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 14:54:39 2012 -0400
>
> Implement ActiveSync MIME support.
>
> framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 65
> ++++++++++--
> 1 files changed, 58 insertions(+), 7 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/c279ad54502758d7be1d47326a05dc62ba4a2480
>
> -----------------------------------------------------------------------
>
> commit 124f6d76b3768b14748c0b011a408a0775da1b97
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 14:55:10 2012 -0400
>
> ws
>
> framework/ActiveSync/lib/Horde/ActiveSync/Wbxml/Encoder.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/124f6d76b3768b14748c0b011a408a0775da1b97
>
> -----------------------------------------------------------------------
>
> commit 1bcee40a0c423df13a1677383fd88d78ac0c94e6
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 15:46:38 2012 -0400
>
> Remove debug output, commented out code etc...
>
> framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php | 5 +----
> framework/ActiveSync/lib/Horde/ActiveSync/State/Sql.php | 9 ---------
> 2 files changed, 1 insertions(+), 13 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/1bcee40a0c423df13a1677383fd88d78ac0c94e6
>
> -----------------------------------------------------------------------
>
> commit 690f45ec96c3ee5786231b5849d96fb7e87a0caf
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 18:40:34 2012 -0400
>
> Must use Horde_ActiveSync::getGetVars() to deal with base64
> encoded binary query parameters.
>
> framework/Rpc/lib/Horde/Rpc/ActiveSync.php | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/690f45ec96c3ee5786231b5849d96fb7e87a0caf
>
> -----------------------------------------------------------------------
>
> commit 8a640c7b8da1c7a3d87fcbd3efc3b086d17ce03e
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date: Thu May 3 18:48:17 2012 -0400
>
> Update package.xml
>
> framework/ActiveSync/package.xml | 29 +++++++++++++++++------------
> 1 files changed, 17 insertions(+), 12 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/8a640c7b8da1c7a3d87fcbd3efc3b086d17ce03e
>
>
> --
> commits mailing list
> Frequently Asked Questions: http://wiki.horde.org/FAQ
> To unsubscribe, mail: commits-unsubscribe at lists.horde.org
--
mike
The Horde Project (www.horde.org)
mrubinsk at horde.org
More information about the dev
mailing list