[dev] [commits] Horde branch develop updated. e797e2aae7ab65da0c7cade906cf923f31fedc5c

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> commit e52eaad8bbfc3afa2e6d2c106b6ef933afc79313
> Author: Jan Schneider <jan at horde.org>
> Date:   Tue Jul 10 20:55:10 2012 +0200
>
>     [jan] Do case-insensitive comparison when matching addresses.
>
>  framework/Mail/lib/Horde/Mail/Rfc822/Address.php |    2 +-
>  framework/Mail/package.xml                       |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/e52eaad8bbfc3afa2e6d2c106b6ef933afc79313

Please revert.  Per RFC 822/2822/5322, the mailbox portion of an  
e-mail address is /platform dependent/.  Thus "FOO at example.com" !=  
"foo at example.com" on all systems.  While most e-mail systems should be  
case insensitive, this is not be 100% guaranteed.

I understand this may be useful, so it is probably best to put this  
code in a matchInsensitive() (or similar) method, and then require the  
calling code to make the decision whether it is willing to ignore this  
distinction.  But the default match algorithm in Horde_Mail_Rfc822 has  
to be one that does byte-for-byte matching.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]