[dev] [commits] Horde branch develop updated. 3675633575bac6b24ed1bc66a39dff6077bcec32

[Michael J Rubinsky]

Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:

> commit 8189313d37faa8d7313caf71ee89e3faea06ec05
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date:   Fri Jul 20 18:39:49 2012 -0400
>
>     Fix generating sourceselect pref UI.
>
>  imp/config/prefs.php |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/8189313d37faa8d7313caf71ee89e3faea06ec05

> commit ba078f5e7f51b8f0541b6584f131439df4ce69e6
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date:   Fri Jul 20 19:25:07 2012 -0400
>
>     This is done in the 'on_init' property in prefs.php.
>
>  imp/lib/Prefs/Special/Sourceselect.php |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/ba078f5e7f51b8f0541b6584f131439df4ce69e6


For the record, I can't find any code that actually calls  
Horde_Core_Prefs_Ui::init() and there are other broken prefs that  
contain init code in that method e.g., Nag_Prefs_Special_TaskAlarms. I  
was not 100% sure these should be moved to the 'on_init' property in  
prefs.php.  Is this the preferred fix, or should we be calling the  
init() method somewhere that we are not?


-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6135 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.horde.org/archives/dev/attachments/20120720/3733c465/attachment.bin>