[dev] gmmktime() vs time() in unit tests.

Jan Schneider jan at horde.org
Mon Aug 6 19:26:58 UTC 2012


Zitat von Ralf Lang <lang at b1-systems.de>:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Some PHPUnit tests fail saying
>
>
> There was 1 error:
>
> 1) Sesha_Unit_Driver_RdoTest::testAddCategory
> gmmktime(): You should be using the time() function instead
>
> Do we adhere to this? (gmmktime without args should be same as time() )

Sounds fine.

> Do we want this in the CODING_STANDARDS for H5?

Probably not necessary. It's not used that often, and we already use  
time() in those case. Just grep for gmmktime() calls in the current  
source.
-- 
Jan Schneider
The Horde Project
http://www.horde.org/



More information about the dev mailing list