[dev] [commits] Horde branch develop updated. b06007e3fb2f80449e5a72039d300ae9ebfb5630

[Jan Schneider]

Zitat von Michael J Rubinsky <mrubinsk at horde.org>:

> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>
>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>
>>> Quoting Jan Schneider <jan at horde.org>:
>>>
>>>>> commit a96460170d3829c4751817d03e1e7f21020b6643
>>>>> Author: Michael M Slusarz <slusarz at horde.org>
>>>>> Date:   Wed Aug 1 15:49:32 2012 -0600
>>>>>
>>>>> [mms] Fix sidebar element wrapping (Ticket #11262).
>>>>>
>>>>> horde/docs/CHANGES                    |    1 +
>>>>> horde/package.xml                     |    2 +
>>>>> horde/templates/sidebar/_row.html.php |   12 +++--
>>>>> horde/templates/tree/_row.html.php    |   21 ++++----
>>>>> horde/themes/default/screen.css       |   84  
>>>>> +++++++++++++-------------------
>>>>> imp/docs/CHANGES                      |    1 +
>>>>> imp/js/dimpbase.js                    |   21 ++++----
>>>>> imp/js/dimpcore.js                    |    2 -
>>>>> imp/lib/Dynamic/Mailbox.php           |    1 -
>>>>> imp/package.xml                       |    2 +
>>>>> imp/themes/default/dynamic/screen.css |    8 +++
>>>>> 11 files changed, 75 insertions(+), 80 deletions(-)
>>>>>
>>>>> http://git.horde.org/horde-git/-/commit/a96460170d3829c4751817d03e1e7f21020b6643
>>>>
>>>> There are two alignment issues since this change:
>>>> - The "Folder Actions" label has too much distance from the icon.
>>>
>>> I spent an hour trying to figure this out last week.  AFAICT, the  
>>> div used for that action is identical to the divs used for the  
>>> mailbox entries.  And I can verify there is no  
>>> padding/margin/border for any element (using both Firebug and  
>>> Chrome's developer tools).  But if you look at the viewport offset  
>>> of the <A> tag, it is indeed somehow shifted 3 pixels to the right  
>>> (41px instead of 38px).
>>>
>>> I really have no clue where this extra padding is coming from.   
>>> And i'd rather not hack a -3px left margin to fix this.  Maybe  
>>> another CSS expert can help me figure this out.
>>
>> There is a CR that is causing this between the div containing the  
>> folder actions drop down icon (class="horde-subnavi-icon  
>> folderoptsImg") and the div containing the Folder Actions <a>  
>> element. Removing the CR between these two divs gets rid of the  
>> extra 3 pixels, though I admit I don't know *why*.

I don't see a CR there.

>>>> - The labels are no longer vertically centered, but  
>>>> bottom-aligned with the icons.
>>>
>>> I don't see this, at least with FF.
>>
>> I see this too on FF/MacOS
>
> .. and this is due to the vertical-align: sub; rule in the  
> horde-subnavi-icon class. Shouldn't this be middle?

Yes, that fixes it.

-- 
Jan Schneider
The Horde Project
http://www.horde.org/