[dev] [commits] Horde branch imap_client_move updated. 810b466f5562cc85ae3ec5f61bb97866f4d5f881

Michael M Slusarz slusarz at horde.org
Mon Oct 29 06:39:58 UTC 2012


Quoting Jan Schneider <jan at horde.org>:

>> commit 123bb80b4e2fe2acf9b87544f266f564f6731404
>> Author: Michael M Slusarz <slusarz at horde.org>
>> Date:   Thu Oct 25 15:45:11 2012 -0600
>>
>>    Revert check for non-array in this branch
>>
>>    Can verify that there is only 1 place we call this method in the code,
>>    and this one place is guaranteed to provide an array.  That's what the
>>    API says, so that's what you must give the method.
>>
>> framework/Imap_Client/lib/Horde/Imap/Client/Cache.php |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/123bb80b4e2fe2acf9b87544f266f564f6731404
>
> In one case it was passed a Horde_Imap_Client_Ids objects though.

That's why I only committed this to the sub-branch, where things have  
changed.  And if it is still passed an Ids object, that needs to be  
fixed (i.e. calling method) rather than patching within the method.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list