[dev] [commits] Horde branch master updated. 447de1bf8b7baa20fdc96649ab6c9af44bcd8208

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Jan Schneider <jan at horde.org>:
>
>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>
>>> Quoting Jan Schneider <jan at horde.org>:
>>>
>>>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>>>
>>>>> The branch "master" has been updated.
>>>>> The following is a summary of the commits.
>>>>>
>>>>> from: ceb6993f44e840dfe5bd20ad64cd529773482050
>>>>>
>>>>> 447de1b Add H5 upgrade task to remove existing sending_charset pref
>>>>>
>>>>> -----------------------------------------------------------------------
>>>>>
>>>>> commit 447de1bf8b7baa20fdc96649ab6c9af44bcd8208
>>>>> Author: Michael M Slusarz <slusarz at horde.org>
>>>>> Date:   Tue Nov 6 11:55:19 2012 -0700
>>>>>
>>>>> Add H5 upgrade task to remove existing sending_charset pref
>>>>>
>>>>> horde/lib/LoginTasks/SystemTask/Upgrade.php |   15 ++++++++++++++-
>>>>> 1 files changed, 14 insertions(+), 1 deletions(-)
>>>>>
>>>>> http://git.horde.org/horde-git/-/commit/447de1bf8b7baa20fdc96649ab6c9af44bcd8208
>>>>
>>>> Changelog?
>>>
>>> This is another one that doesn't make any sense.  People upgrading  
>>> to 5.0.1 WON'T see this, so putting a changelog entry in there is  
>>> just confusing.
>>>
>>> And this is really behind the scenes stuff anyway (after the  
>>> discussion on the mailing list today, realized that this 100% must  
>>> be reset or else things won't work properly).
>>>
>>> Those that are already upgraded are screwed.  They will need to  
>>> manually change this preference value if it is set in the storage  
>>> backend.
>>
>> If this isn't triggered for people who already upgrade, and if we  
>> add this to 5.0.1 anyway, why don't you set the upgrade version to  
>> 5.0.1?
>
> Oh, and to the original issue: I think silently removing users'  
> preferences, even if it is the only thing that makes sense,  
> absolutely deserves a changelog entry, if not even an entry to  
> UPGRADING.

I'll agree that an UPGRADING entry is probably necessary.  Still  
disagree about changelog entry.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]