[dev] [commits] Horde branch master updated. a033f5735ffd8d146b12a34d5c00f9ba797d9e0b

[Chuck Hagenbuch]

Quoting Michael J Rubinsky <mrubinsk at horde.org>:

> Quoting Chuck Hagenbuch <chuck at horde.org>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: 378101b4842fcf47f5a61a590e9e1e3d8c517ae9
>>
>> 6e87d94 If $style is already an Ansel_Style object, just return it
>> 21f060e Need to include inline script in API responses too
>> a033f57 Need to include the date params!
>>
>> -----------------------------------------------------------------------
>>
>> commit 6e87d940b2d79dd67ea8a5fe8cda123360877fb8
>> Author: Chuck Hagenbuch <chuck at horde.org>
>> Date:   Sat Feb 16 16:42:48 2013 -0500
>>
>>   If $style is already an Ansel_Style object, just return it
>>
>> ansel/lib/Ansel.php |    6 +++++-
>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/6e87d940b2d79dd67ea8a5fe8cda123360877fb8
>
>
> I know I have things in a bit of an in-between state right now, but  
> where were we passing an Ansel_Style object to this method? The API  
> indicates it is supposed to be passed a string.
>
> Is this so you can pass your own Ansel_Style object into Ansel's  
> API? If so, in addition to updating the involved phpdoc, we should  
> also probably extend the Ansel_Api methods involved so we can pass  
> an array instead of an object to be more friendly to Rpc clients.

I'm passing a string in the API, but somewhere it was getting  
converted to an Ansel_Style object. It was during an API call though.

I can dig a bit if you want to ping me on IRC tomorrow or so...
-chuck

-chuck