[dev] [commits] Horde branch master updated. b31b393c5d7952e4c7391cc41c0b91b24a593fa6

[Michael M Slusarz]

Quoting Rui Carneiro <rui.carneiro at portugalmail.net>:

> On Wed, Feb 20, 2013 at 5:50 AM, Michael M Slusarz <slusarz at horde.org>wrote:
>
>> commit b31b393c5d7952e4c7391cc41c0b91b24a593fa6
>> Author: Michael M Slusarz <slusarz at horde.org>
>> Date:   Tue Feb 19 22:45:08 2013 -0700
>>
>>     [mms] Use csstidy library to parse CSS files when creating static CSS
>> (Bug #12043).
>>
>>     Should be more efficient, since we don't have to search for url
>>     parameters three different times.
>>
>>     Also, should be more robust (fixes support for multiple urls in a
>> single
>>     CSS style).
>>
>>     Side effect: $conf['cachecssparams']['compress'] is no longer needed -
>>     since we are already necessarily parsing the CSS, there's no reason not
>>     to compress when saving.  Will remove the option in Horde 5.1 for
>>     clarity.
>>
>>  framework/Core/lib/Horde/Themes/Css.php |   98
>> ++++++++++++++++++-------------
>>  framework/Core/package.xml              |    2 +
>>  2 files changed, 58 insertions(+), 42 deletions(-)
>>
>>
>> http://git.horde.org/horde-git/-/commit/b31b393c5d7952e4c7391cc41c0b91b24a593fa6
>
>
>
> I am using some CSS3 rules on my Horde installation and after this patch i
> can't cache my css at all.
>
> CssTidy has really poor support for CSS3 rules and without the "compress"
> conf I can't avoid CssTidy being
> used and to destroy my CSS (not only the CSS3 code but some "standard" code
> below that also).
>
> Any workaround suggested?

1) Patch CssTidy to work with CSS 3 rules
2) Re-write CssTidy to work with CSS 3 rules.
3) Add your local rules as an External stylesheet  
(Horde_PageOutput#addStylesheet()), which isn't parsed like Horde  
stylesheets.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]