[dev] Horde_History::removeByParent() block size

[Jan Schneider]

Zitat von Thomas Jarosch <thomas.jarosch at intra2net.com>:

> On Friday, 15. March 2013 19:07:20 Michael M Slusarz wrote:
>> > The removeByNames() function, also used for deleting entries,
>> > sends all entries to the database in one go.
>> >
>> > @MMS: What's the reason for splitting up the request?
>>
>> Are you asking me?  I have no idea.  I didn't write this code.
>>
>> Looks like I consolidated code from other places (e.g. nag, kronolith):
>>
>> commit 33eb7243328cac82e4f43fbc1060a9c089d7efb6
>> Author: Michael M Slusarz <slusarz at curecanti.org>
>> Date:   Sat Jan 30 11:53:52 2010 -0700
>>
>>      Add Horde_History::removeByParent()
>>
>> But that was a housekeeping thing (moving code from apps ->
>> framework).  I have no insight on what this code actually does.
>
> Thanks for checking.
>
> I think the basic idea of that function is to clean up the history database
> f.e. when a share gets deleted. I've looked at the current 'delete share'
> implementation of kronolith which -marks- all events as deleted instead of
> deleting entries in the database. This is much better for synced clients.
>
> Digging in the code history, it looks like removeByParent()
> was often used by removeUserData() to clean up the history database.
> I guess we don't need or want it anymore.
>
> Should we kill removeByParent()?
>
> Thomas

We can't because that's a BC break. Mark as deprecated and  
to-be-removed in Horde 6.
-- 
Jan Schneider
The Horde Project
http://www.horde.org/