[dev] CSS Parsing class

Jan Schneider jan at horde.org
Fri Mar 22 13:38:40 UTC 2013


Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael M Slusarz <slusarz at horde.org>:
>
>> Saying we need to leave the original BROKEN code in place because  
>> that's the status quo is absolutely absurd!  By that reasoning we  
>> should never fix bugs because it might break current behavior.  
>> (Sure enough, the code implemented to fix logging appears to be  
>> causing some unwanted behavior for new people.  But does that mean  
>> we should have not implemented the original bug fix?  Of course not.)
>
> For the record... I will agree/admit that the current state of  
> affairs is not optimal.  But there comes a point where you have to  
> do the cost/benefit analysis of making this change.  And here the  
> analysis is heavily in favor of fixing vs. letting a fix for a  
> prominent issue wait for some yet-unreleased version of the software  
> of which certain individuals may not be able to update to for years  
> (i.e.: I just found out that Fedora 18 ships Horde 3/IMP 4.  That's  
> not tremendously useful).

I don't buy this argument at all. By the same reasoning you could  
argue against exchanging the library now, because it could happen that  
there is some undetected bug in the release that affects a lot of  
systems, and due to some bad fortune, exactly that version is picked  
for a LTS release that's going to be shipped for the next few years.
And since when do we decide when or how to release a piece of software  
depending on some distributions that constantly ship outdated,  
unsupported releases of our software? Those really have worse problems  
than a buggy CSS compressor.

> This may be a different case if the csstidy code was not  
> lacking/blatantly broken in multiple different ways.  But it isn't.   
> That's just the situation we have.
>
> The issue reported regarding ',' separators was indeed a 2-line fix.  
>  IMHO there's a big difference between new code that might need to  
> be tweaked vs. trying to duct tape the csstidy code even more with  
> absolutely no guarantee that it is going to work properly.
>
> michael
>
> ___________________________________
> Michael Slusarz [slusarz at horde.org]


-- 
Jan Schneider
The Horde Project
http://www.horde.org/



More information about the dev mailing list