[dev] [commits] Horde branch FRAMEWORK_5_0 updated. 00b796b064a73a3429775abccd7e41aba253fc2a

Thomas Jarosch thomas.jarosch at intra2net.com
Fri Apr 19 07:42:31 UTC 2013


On Thursday, 18. April 2013 11:15:47 Michael J Rubinsky wrote:
> >> http://git.horde.org/horde-git/-/commit/00b796b064a73a3429775abccd7e41aba253fc2a
> > 
> > Regarding the exception handler, what about adding a debug log?
> 
> It's logged when the calling code catches the exception. E.g., see
> Horde_ActiveSync_Sync#syncronize()

Ok. I still don't get why Horde_ActiveSync_Imap_Adapter:getMessages()
catches the exception and hides it.

If the code is refactored later on or getMessages() gets re-used,
we might miss the information that something was wrong.

Can't we log it "more local" at the place the exception is caught?

Thanks for your patience :)
Thomas



More information about the dev mailing list