[dev] [commits] Horde branch master updated. d9642d7776410243da77d669c457abec3f5959f2

[Thomas Jarosch]

On Wednesday, 15. May 2013 11:08:09 Jan Schneider wrote:
> > -----------------------------------------------------------------------
> > 
> > commit f91bcfda7919b13cab4ab668411b3f187ad25a8f
> > Author: Chuck Hagenbuch <chuck at horde.org>
> > Date:   Tue May 14 23:38:32 2013 -0400
> > 
> >     Add memcache caching of History info - drastically cuts number
> > 
> > of SQL queries when loading Nag task list, for instance.
> > 
> >     Maybe should be reworked to use HashTable now?
> >  
> >  framework/Core/lib/Horde/Core/Factory/History.php |    8 +++++-
> >  framework/History/lib/Horde/History.php           |   30
> > 
> > ++++++++++++++++++++-
> > 
> >  framework/History/lib/Horde/History/Sql.php       |    3 ++
> >  3 files changed, 39 insertions(+), 2 deletions(-)
> > 
> > http://git.horde.org/horde-git/-/commit/f91bcfda7919b13cab4ab668411b3f18
> > 7ad25a8f
>
> This should be a generic Horde_Cache instance. And you must bump the
> minor version, and add a @since tag. Also, Horde_Core can just require
> that version of Horde_Cache and use the setter unconditionally.

I'm getting unit test failures related to this:

# phpunit --filter testSynchronize -d include_path=/var/www/horde/libs:/usr/share/pear Unit/Data/Query/History/BaseTest.php
PHPUnit 3.7.18 by Sebastian Bergmann.

Configuration read from /datastore/DEVEL/horde/framework/Kolab_Storage/test/Horde/Kolab/Storage/phpunit.xml

E

Time: 1 second, Memory: 5.50Mb

There was 1 error:

1) Horde_Kolab_Storage_Unit_Data_Query_History_BaseTest::testSynchronize
Undefined property: Horde_History_Mock::$_memcache
...


Adding a "protected $_memcache" class member to Horde_History fixes this.

Thomas