[dev] [commits] Horde branch master updated. f61fdaee6bb5fee15abe792219b02a0947925028

Michael J Rubinsky mrubinsk at horde.org
Wed Jul 3 13:48:52 UTC 2013


Quoting Chuck Hagenbuch <chuck at horde.org>:

> The branch "master" has been updated.
> The following is a summary of the commits.
>
> from: 5643dee22aa524776bd6caf14625c3acc3858002
>
> f61fdae Right now _getRelatedTags() is the difference between my  
> task list loading in .5 seconds and it taking 4-5 seconds to load,  
> even after the Horde_History cache improvements. It also is getting  
> tags that aren't from the current view because Future tasks aren't  
> accounted for.
>
> -----------------------------------------------------------------------
>
> commit f61fdaee6bb5fee15abe792219b02a0947925028
> Author: Chuck Hagenbuch <chuck at horde.org>
> Date:   Wed Jul 3 00:33:57 2013 -0400
>
>     Right now _getRelatedTags() is the difference between my task  
> list loading in .5
>     seconds and it taking 4-5 seconds to load, even after the  
> Horde_History cache
>     improvements. It also is getting tags that aren't from the  
> current view because
>     Future tasks aren't accounted for.
>
>     I think if we want to keep the related tasks top bar, we need to  
> put that list
>     together as we go through the list of tasks, where we're already  
> fetching the
>     tags for each task and displaying them next to each one. That'll  
> avoid a *lot*
>     of unnecessary queries.

This may be true, but can you wait until there is some fix in place  
before removing it in the stable git branch? This way, we won't  
accidentally remove this functionality from the next bug fix release.

FWIW, this is also the same mechanism that we use in all the apps that  
use tags-as-navigation such as Trean and Ansel. I think we need to  
improve either Content_Tagger or Core_TagBrowser instead of moving the  
browsing functionality out of it and into the application-land code.

-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2200 bytes
Desc: PGP Public Key
URL: <http://lists.horde.org/archives/dev/attachments/20130703/92f19c9a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6062 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20130703/92f19c9a/attachment-0001.bin>


More information about the dev mailing list