[dev] Error in LDAP driver for passwd

[Andy Dorman]

On 06/10/2013 03:44 AM, Jan Schneider wrote:
>
> Zitat von Laurent Roudier <laurent_roudier at yahoo.fr>:
>
>> Hi everybody
>> I'am not sure, but I think I found a Bug in the LDAP driver of passwd
>> application (version 5.0.0)
>> In the file " / passwd / lib / Driver / Ldap.php"
>> Line : 97
>>
>>     protected function _changePassword($user, $oldpass, $newpass)
>> must be change by
>>
>>     protected function _changePassword($username, $oldpass, $newpass)
>>
>>
>> Laurent
>
> Please file a ticket.

FWIW, this is not as simple as making the change above.  The $user 
variable that is passed into the function IS used correctly in at least 
one place in the function.  The correct fix is to stick with the input 
variable, $user or $username, throughout the function.

I could not find a ticket that addresses this issue...So I submitted 
one... http://bugs.horde.org/ticket/12519.  I suggested using $user 
throughout, but it would be just as easy to use $username everywhere.

-- 
Andy Dorman
FanMail.com
Ironic Design, Inc.
AnteSpam.com, HomeFreeMail.com, ComeHome.net

CONFIDENTIALITY NOTICE: This message is for the named person's use only. 
It may contain confidential, proprietary or legally privileged 
information. No confidentiality or privilege is waived or lost by any 
erroneous transmission. If you receive this message in error, please 
immediately destroy it and notify the sender. You must not, directly or 
indirectly, use, disclose, distribute, or copy any part of this message 
if you are not the intended recipient.