[dev] [commits] Horde branch master updated. f61bc298362194bab0878bacc85b504798898200

[Michael J Rubinsky]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Thomas Jarosch <thomas.jarosch at intra2net.com>:
>
>>>> http://git.horde.org/horde-git/-/commit/8a55b3d7e36c2615fd6f7d474a8eaae7
>>>> 6f77c716
>>> Not super clear what is going on here.  But if you are trying to do
>>> something like identifying when the status of the mailbox has changed,
>>> all you need is Horde_Imap_Client_Base#getSyncToken().
>>>
>>> It handles things like the presence of CONDSTORE transparently and
>>> uses other methods if not available.
>>
>> haha, is there anything that the Imap_Client doesn't do? ;)
>>
>> The ActiveSync code is almost identical. Main difference:
>> - it uses the new STATUS_FORCE_REFRESH flag
>
> See the bug ticket (don't have handy) where I suggested a global  
> IMAP object flag that turns on FORCE_REFRESH for all status() calls,  
> even those that occur internally.
>
>> - we have better diagnostics why we think the server changed
>
> But you can already get all this information from syncing without  
> having to duplicate this code.  See: Horde_Imap_Client_Base#sync(),  
> which returns a Horde_Imap_Client_Data_Sync object.  Better still -  
> this method will automatically/transparently update the cache when  
> checking the sync status.


Am I reading the code correctly in that without MODSEQ, a sync will  
always report that there are flag changes?
-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2200 bytes
Desc: PGP Public Key
URL: <http://lists.horde.org/archives/dev/attachments/20130822/7521b348/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6062 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20130822/7521b348/attachment-0003.bin>