[dev] [commits] Horde branch master updated. 5d99d130fb23f205b007ddde9a84b79a092acd3b

[Michael J Rubinsky]

Quoting Thomas Jarosch <thomas.jarosch at intra2net.com>:

> Hi MJR,
>
> On Saturday, 31. August 2013 19:00:53 you wrote:
>> commit 5d99d130fb23f205b007ddde9a84b79a092acd3b
>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>> Date:   Sat Aug 31 14:58:51 2013 -0400
>>
>>     Fix OPTIONS/SYNC loop due to incorrect handling of MS-RP header.
>>
>>     Some devices will reset sync state everytime the MS-RP header is
>>     sent, regardless of if the versions are newer or not. Track the
>>     last announced version header sent to the devce and only send
>>     the MS-RP header if the versions are different.
>>
>>  framework/ActiveSync/lib/Horde/ActiveSync.php        |   10 +++-
>>  framework/ActiveSync/lib/Horde/ActiveSync/Device.php |   41
>> ++++++++++++++---- 2 files changed, 39 insertions(+), 12 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/5d99d130fb23f205b007ddde9a84b79a09
>> 2acd3b
>
> resetting the sync state is the official behavior for the X-MS-RP header:
>
> -------------------------------------------
> http://msdn.microsoft.com/en-us/library/gg672028%28v=exchg.80%29.aspx
>
> This header is optional. Its presence in a response indicates that a
> condition on the server (such as a server upgrade) requires the client to
> discard its local data and resynchronize. The value of this header indicates
> the protocol versions the server supports.
> -------------------------------------------
>
>
> -> Good we fixed this :)

Yeah, I read that, but since some of my (apparently broken) test  
clients would only reset the state if the previous  version number was  
different, I assumed that was the way it was supposed to work. You  
would think I should have known better than to trust one or two  
clients :)



-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2200 bytes
Desc: PGP Public Key
URL: <http://lists.horde.org/archives/dev/attachments/20130903/169d2e1a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5849 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20130903/169d2e1a/attachment-0001.bin>