[dev] [commits] Horde branch master updated. 96483e0d91a027c338b703995e0b123b31684488

[Michael M Slusarz]

Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:

> commit 4faaf153875911d05a2329f693ff767cefdc2e7c
> Author: Michael J Rubinsky <mrubinsk at horde.org>
> Date:   Mon Sep 23 11:24:56 2013 -0400
>
>     This seems to prevent a PHP bug from being triggered.
>
>     Without hex-encoding of control characters, PHP is segfaulting on
>     numerous platforms with certain strings. Still working out the
>     exact string combinations that trigger this for reporting to PHP.
>
>  framework/Mime/lib/Horde/Mime/Part.php |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> http://github.com/horde/horde/commit/4faaf153875911d05a2329f693ff767cefdc2e7c
> http://git.horde.org/horde-git/-/commit/4faaf153875911d05a2329f693ff767cefdc2e7c

This is being reverted.  You can't do this.  This breaks things like  
generating PGP and flowed messages, where spaces MUST NOT be encoded  
in quoted-printable data.  To say nothing of the size of messages sent  
now (this is way less efficient than base64).

The correct fix would be to manually change the encoding of the part  
to base64 at the location you are seeing issues until you can figure  
out the problem.  However, the solution is not to cripple the software  
for everyone else that is using it normally.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]