[dev] [commits] Horde branch master updated. 227e17105ca4e5878f2110c5ade26a3163782a0b

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>
>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>
>>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>>
>>>> commit d4301122ef66facb7080f68271c3f02ed8547d9d
>>>> Author: Michael M Slusarz <slusarz at horde.org>
>>>> Date:   Wed Oct 16 15:03:18 2013 -0600
>>>>
>>>>  Initial commit for Socket_Client package
>>>>
>>>> framework/Socket_Client/doc/Horde/Socket/Client/COPYING       |   
>>>> 458 +++++++++
>>>> framework/Socket_Client/lib/Horde/Socket/Client.php           |  198 ++++
>>>> framework/Socket_Client/lib/Horde/Socket/Client/Exception.php |   28 +
>>>> framework/Socket_Client/package.xml                           |   95 ++
>>>> 4 files changed, 779 insertions(+), 0 deletions(-)
>>>> create mode 100644 framework/Socket_Client/doc/Horde/Socket/Client/COPYING
>>>> create mode 100644 framework/Socket_Client/lib/Horde/Socket/Client.php
>>>> create mode 100644  
>>>> framework/Socket_Client/lib/Horde/Socket/Client/Exception.php
>>>> create mode 100644 framework/Socket_Client/package.xml
>>>>
>>>> http://github.com/horde/horde/commit/d4301122ef66facb7080f68271c3f02ed8547d9d
>>>> http://git.horde.org/horde-git/-/commit/d4301122ef66facb7080f68271c3f02ed8547d9d
>>>
>>> Thoughts on using namespaces going forward instead of underscores?  
>>>  PSR-0 wise there is no issue mixing the two, and IIRC the only  
>>> thing preventing us from doing this back during the initial H4  
>>> release is that it requires 5.3.0 (since we required 5.2.0 for H4).
>>
>> Personally, I'd prefer to do this all or nothing to be consistent  
>> from a CS point of view. I don't want to have to remember that one  
>> class is Horde\SomeLibrary\Class and another is Horde_Library_Class.

Agreed.

> Except this argument is irrelevant for new libraries.  You  
> necessarily are going to have to look at the documentation the first  
> time so you will know exactly which format is required.

How is this irrelevant? You still have to remember which libraries use  
namespaces and which don't. Inconsistent usage of namespaces in the  
Horde libraries is an absolute no-go.

> I would personally vote for namespacing, since that is the more  
> correct PHP way of doing things now.  If we are interested in having  
> our libraries used outside of Horde applications, this is the way to  
> go.

It's not a showstopper to not use namespaces, but I agree that we  
should convert to namespaces for Horde 6. Since we have a bunch of new  
features for Horde 5.2 that we should concentrate on, I suggest to  
tackle the namespace conversion after the release of 5.2.
-- 
Jan Schneider
The Horde Project
http://www.horde.org/