[dev] [commits] Horde branch master updated. f7b75dbcebed550d35027b95d70b65bafb5723bf

[Thomas Jarosch]

On Thursday, 17. October 2013 09:01:30 Michael J Rubinsky wrote:
> > If you tweak the code anyway: No need to use strlen()
> > to check if a string is empty ;)
> 
> Well, we still need to only add the OR after the first set of
> $conditions, so we *do* still need to check that. Either way, I
> refactored that anyway to use an array and explode() instead since
> it's a bit cleaner to read.
> 
> Let me know once your testing is (hopefully) successful and I'll
> release the next package. I want to get these fixes out in a released
> package before I merge the 2_9_0 stuff into master.

I meant it's better to use "!empty($conditions)" instead of 
"strlen($conditions)" for the emptiness check. The logic stays the same.

Anyway, I was just about to update my local package
and will fetch the latest changes *now* ;)

Thomas