[dev] [commits] Horde branch master updated. 760524934f11365acac54b36a4ced40996062ebe

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

>> e6a7d00 Released Horde_Socket_Client-1.0.0
>
> I thought we made it clear that using namespaces in Horde 5 is NOT  
> acceptable!? Why did you ignore what we said?

This was an oversight.  While I disagree that anything was formally  
decided, Horde_Smtp had a critical issue -- albeit rare -- that needed  
to be fixed.  And there was no reliable way to do this without  
releasing both since we don't have separate git repos for libraries  
(git revert-ish like behavior is not acceptable).  I did not think of  
namespacing issues when releasing Socket_Client.  But it was the  
correct decision - the critical bug needed to be fixed.

This doesn't affect anybody though.  I believe one of the arguments  
against namespacing was "people won't know which form of namespacing  
to use."  Huh?  That argument makes zero sense.  Either that or I am a  
terrible coder because I need to look at the documentation before  
writing a function call when apparently everybody else somehow  
magically knows how to call Socket_Client's constructor which, again,  
didn't exist until a week ago, and knows what sort of Exceptions it  
may return.  I agree that you can't change EXISTING code.  But any  
argument about a developer not being aware which namespacing method to  
use for an entirely new library is completely disingenuous and simply  
a non-starter for me.  So we can release a new major version of the  
package just to change the namespacing rules, but that seems like a  
waste of time for no gain.

Whether we want to do it or not is still an open question.  I'm not  
convinced myself it is the correct way to go.

But **PLEASE** stop using "Horde 5 library" as a justification here.   
THERE IS NO SUCH THING AS A HORDE 5 LIBRARY (with the exception of  
Horde_Core)!!  I thought that was made clear long ago.

Socket_Client has absolutely NOTHING to do with H5.  Nothing.
Horde_Text_Filter has absolutely NOTHING to do with H5.  Nothing.
Horde_Support has absolutely NOTHING to do with H5.  Nothing.
etc.

Just because they all live together in our git repo doesn't change any  
of this. This was all discussed long ago on the list.  And I'll agree  
that the namespace decision might fall under the rubric of general  
Horde coding standards.  But this decision has nothing to do what  
we've done in other "H5 libraries", since that term - outside of  
Horde_Core - has no meaning.

We absolutely must not be releasing new major versions of libraries  
for H6.  Socket_Client is absolutely not going to be bumped to 2.0 for  
H6.  That's because Socket_Client has absolutely nothing to do with H6.

If there continues to be this belief that libraries are somehow tied  
to applications, that is a core, fundamental issue I have that is not  
going to change and makes me concerned going forward.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]