[dev] [commits] Horde branch kronolith_4_2 updated. d93e04af96c2e80dd8d9cd3f1824f6f4faffd73a

Jan Schneider jan at horde.org
Fri Nov 1 15:34:08 UTC 2013


Zitat von Michael J Rubinsky <mrubinsk at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> Zitat von "Michael J. Rubinsky" <mrubinsk at horde.org>:
>>
>>> The branch "kronolith_4_2" has been updated.
>>> The following is a summary of the commits.
>>>
>>> from: e983c746d12f7a0219901da5a31d73d82100832e
>>>
>>> 865ee4c Expose Kronolith::getDefaultCalendar() via the API.
>>> d93e04a @since
>>>
>>> Summary:  
>>> http://github.com/horde/horde/compare/e983c746d12f7a0219901da5a31d73d82100832e...d93e04af96c2e80dd8d9cd3f1824f6f4faffd73a
>>>
>>> -----------------------------------------------------------------------
>>>
>>> commit 865ee4c73890a1f2b1862fc88231c45b343139ef
>>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>>> Date:   Thu Oct 31 11:15:19 2013 -0400
>>>
>>>   Expose Kronolith::getDefaultCalendar() via the API.
>>>
>>> kronolith/lib/Api.php |   10 ++++++++++
>>> 1 files changed, 10 insertions(+), 0 deletions(-)
>>>
>>> http://github.com/horde/horde/commit/865ee4c73890a1f2b1862fc88231c45b343139ef
>>> http://git.horde.org/horde-git/-/commit/865ee4c73890a1f2b1862fc88231c45b343139ef
>>
>> Shouldn't those rather be called getDefaultSource(), matching the  
>> sources() method? Especially since Kronolith will support non-share  
>> default calendars in the future, and Turba already does right now.
>
> I did this to be consistent across all of the apps. Turba already  
> has a getDefaultShare() method.

Please add a @todo then so that we change this in H6
-- 
Jan Schneider
The Horde Project
http://www.horde.org/



More information about the dev mailing list