[dev] [PATCH] ActiveSync: Fix email sync error on corner case

[Michael J Rubinsky]

Quoting Thomas Jarosch <thomas.jarosch at intra2net.com>:

> On Thursday, 12. December 2013 17:11:01 Thomas Jarosch wrote:
>> Hmm. What about the array_diff() call in setSoftDeleted()?
>> I think it will destroy the array values.
>
> ah, forget about that, it's not executed for NON-CONDSTORE servers.
> Guess it must be something similar though.

Yeah. The only other place that $this->_messages is mangled is in  
updateState(), and it at least *looks* correct to me...

I think that the data structure is rather a side effect of the  
exception being thrown, and not the cause. If you look at  
setChanges(), the exception is thrown before the $flags are dealt  
with, so when updateState() is called, $flags are empty when it's  
combined with $this->_messages.
-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5849 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20131212/7fe5475b/attachment.bin>