[dev] [commits] Horde branch master updated. b83e1fca5aaa640fab411bac4eb0c129fb7503ad

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> commit 2de4c68c208a0341745d5a3c8d7ccdfe32824849
>>> Author: Jan Schneider <jan at horde.org>
>>> Date:   Thu Jan 30 10:49:46 2014 +0100
>>>
>>>   This is not necessary.
>>>
>>>   There is no r() function, just a Horde_Translation::r() method.
>>>
>>> horde/lib/core.php |    7 -------
>>> 1 files changed, 0 insertions(+), 7 deletions(-)
>>>
>>> http://github.com/horde/horde/commit/2de4c68c208a0341745d5a3c8d7ccdfe32824849
>>> http://git.horde.org/horde-git/-/commit/2de4c68c208a0341745d5a3c8d7ccdfe32824849
>>
>> This doesn't work.  There is no available default Horde_Translation  
>> access to an application - Horde_Translation is an abstract class,  
>> so Horde_Translation::r() is not available.
>>
>> michael
>>
>> ___________________________________
>> Michael Slusarz [slusarz at horde.org]
>
> Did you look at the patch? I'm just removing the r() placeholder,  
> because it doesn't make any sense.

Yes.

Why doesn't r() make sense?  Put another way... how does one define a  
non-translated string in, say, kronolith?  Horde_Translation::r('foo')  
won't work.  What is the alternative?  (If the alternative is that  
Kronolith has to extend Horde_Translation, that is not documented  
anywhere.)

That's what r() was intended for.  You've removed that functionality  
without providing an alternative, or at least documenting it.

michael
-- 

___________________________________
Michael Slusarz [slusarz at horde.org]