[dev] [commits] Horde branch master updated. f174f08002872dab2019bcca58175749f598bb6a

Michael M Slusarz slusarz at horde.org
Mon Mar 3 19:00:38 UTC 2014

Quoting Michael J Rubinsky <mrubinsk at horde.org>:

> Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>> from: 5001def3d7521ce8cdfdcf6317a3c5617693494e
>> f174f08 Fix obtaining BINARY.SIZE.
> To clarify, this was broken by an incorrect fix for Bug: 12992.

This is incorrect.

Bodypart size queries are added using the  
Horde_Imap_Client_Fetch_Query#bodyPartSize() method:

     public function bodyPartSize($id)
         $this->_data[Horde_Imap_Client::FETCH_BODYPARTSIZE][$id] = true;

As seen, the MIME ID is stored in the KEY, not the value.  Thus, this  
line is correct:

foreach (array_keys($c_val) as $key) {

Your patch (by removing array_keys()) is simply changing the code to  
do a bodypartsize fetch on MIME ID 1 (boolean true = integer 1) for  
every bodypartsize query.

The problem remains that the calling code is setting MIME ID = 0 for  
Horde_Imap_Client_Fetch_Query#bodyPartSize().  That is not allowed  
(bodypartsize only works on a specific mime part, not the entire  
message which is what we treat MIME ID 0 as).

This will be reverted.


Michael Slusarz [slusarz at horde.org]

More information about the dev mailing list